Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Polish translation for docs/pl/docs/help-fastapi.md #10121

Merged

Conversation

romabozhanovgithub
Copy link
Sponsor Contributor

Relates to #9195

This PR is a translation of docs/pl/docs/help-fastapi.md

This is my first PR to this repository. I would appreciate a code review. Please let me know if it has any problems.

@tiangolo
Copy link
Owner

📝 Docs preview for commit 52aa099 at: https://2c51a7d2.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

📝 Docs preview for commit 679878a at: https://1e5494a5.fastapitiangolo.pages.dev

Copy link
Contributor

@isulim isulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of translation is ok, but I have some suggestions.

Większość tłumaczenia jest ok, ale mam trochę propozycji.

docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
romabozhanovgithub and others added 14 commits August 31, 2023 23:57
Co-authored-by: Igor Sulim <30448496+isulim@users.noreply.github.com>
Co-authored-by: Igor Sulim <30448496+isulim@users.noreply.github.com>
Co-authored-by: Igor Sulim <30448496+isulim@users.noreply.github.com>
Co-authored-by: Igor Sulim <30448496+isulim@users.noreply.github.com>
Co-authored-by: Igor Sulim <30448496+isulim@users.noreply.github.com>
Co-authored-by: Igor Sulim <30448496+isulim@users.noreply.github.com>
Co-authored-by: Igor Sulim <30448496+isulim@users.noreply.github.com>
Co-authored-by: Igor Sulim <30448496+isulim@users.noreply.github.com>
Co-authored-by: Igor Sulim <30448496+isulim@users.noreply.github.com>
Co-authored-by: Igor Sulim <30448496+isulim@users.noreply.github.com>
Co-authored-by: Igor Sulim <30448496+isulim@users.noreply.github.com>
Co-authored-by: Igor Sulim <30448496+isulim@users.noreply.github.com>
Co-authored-by: Igor Sulim <30448496+isulim@users.noreply.github.com>
Co-authored-by: Igor Sulim <30448496+isulim@users.noreply.github.com>
@romabozhanovgithub
Copy link
Sponsor Contributor Author

romabozhanovgithub commented Aug 31, 2023

@isulim Thanks for your review, really appreciate

@tiangolo
Copy link
Owner

📝 Docs preview for commit 026faf5 at: https://fc058b53.fastapitiangolo.pages.dev

@isulim
Copy link
Contributor

isulim commented Aug 31, 2023

Hello @tiangolo
Why does smokeshow/coverage fail on file tests/test_openapi_examples.py?
I never changed this file.

@romabozhanovgithub
Copy link
Sponsor Contributor Author

Hello @tiangolo Why does smokeshow/coverage fail on file tests/test_openapi_examples.py? I never changed this file.

Same here

@tiangolo
Copy link
Owner

tiangolo commented Sep 1, 2023

It seems it was a line in a dummy test I left uncovered and I probably didn't notice while Smokeshow was having errors. But now I added it, and updating the branch here should solve it. 🤓

@tiangolo
Copy link
Owner

tiangolo commented Sep 1, 2023

📝 Docs preview for commit 5c4fcab at: https://ae496c77.fastapitiangolo.pages.dev

@tiangolo tiangolo added awaiting-review lang-pl Polish translations labels Sep 2, 2023
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
docs/pl/docs/help-fastapi.md Outdated Show resolved Hide resolved
Co-authored-by: Antek S. <antoni.szych@gmail.com>
@romabozhanovgithub
Copy link
Sponsor Contributor Author

@isulim @bluefish6 Thanks for your review and suggestions!

Copy link
Contributor

@bluefish6 bluefish6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tiangolo
Copy link
Owner

📝 Docs preview for commit 6788ebc at: https://e8b63855.fastapitiangolo.pages.dev

@romabozhanovgithub
Copy link
Sponsor Contributor Author

@tiangolo Looks like we have 2 approves there

@tiangolo
Copy link
Owner

📝 Docs preview for commit 2d2e711 at: https://17f45cfb.fastapitiangolo.pages.dev

@tiangolo tiangolo changed the title 🌐Add Polish translation for docs/pl/docs/help-fastapi.md 🌐 Add Polish translation for docs/pl/docs/help-fastapi.md Sep 22, 2023
@tiangolo
Copy link
Owner

Thanks @romabozhanovgithub! 🙇

And thanks for the reviews @bluefish6 and @isulim 🍰

@tiangolo tiangolo merged commit 8924631 into tiangolo:master Sep 22, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-pl Polish translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants