Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add German translation for docs/de/docs/tutorial/path-params.md #10290

Merged

Conversation

nilslindemann
Copy link
Contributor

@nilslindemann nilslindemann commented Sep 20, 2023

There is an accidental overlap with #10281 by DevSpace88.

← async.md (#10449)
β†’ tutorial/query-params.md (#10293)

German translation progress

* Full translation
* In sync with current en/docs/tutorial/path-params.md
* Hand-translated (Google translate rarely used)
* Checked for errors using LanguageTool
* Manually checked
@tiangolo
Copy link
Owner

πŸ“ Docs preview for commit 0252f0b at: https://8488bdff.fastapitiangolo.pages.dev

@nilslindemann
Copy link
Contributor Author

nilslindemann commented Sep 20, 2023

@tiangolo The German translation for the specific page is missing from most of these commit previews. I am sorry if I missed something. Do I have to update any global index file?

I have the same issue in the local dev server in these branches. But it works in my work-branch, which has all the commits applied.

@DevSpace88
Copy link

DevSpace88 commented Sep 20, 2023

@nilslindemann
That's because you forgot to put path-params.md in the directory tutorial
In your commit your path is docs/de/docs/path-params.md
it should be:
docs/de/docs/tutorial/path-params.md

But, I actually did this exact PR yesterday evening or tonight. I also noticed, that you did other PR's that were for files that also already had a PR.
Please check the open PR's before starting a new one.

@tiangolo
Copy link
Owner

πŸ“ Docs preview for commit 3809f5b at: https://aa1ff140.fastapitiangolo.pages.dev

@nilslindemann
Copy link
Contributor Author

nilslindemann commented Sep 20, 2023

@nilslindemann That's because you forgot to put path-params.md in the directory tutorial In your commit your path is docs/de/docs/path-params.md it should be: docs/de/docs/tutorial/path-params.md

Sorry, my mistake. Fixed.

But, I actually did this exact PR yesterday evening or tonight. I also noticed, that you did other PR's that were for files that also already had a PR. Please check the open PR's before starting a new one.

I checked all PRs on Monday (23-9-18). Unfortunately, that was before you made your PR. Shit :-(

I will from now on post here before I start a new translation. I would be grateful if others could do so too, so that this does not happen anymore.

Regarding the other commits, there were a few errors, and some translations were not in sync or just partially translated. The authors did not respond in their PRs. So I decided to take them as base and create a bunch of new PRs.

I am planning to go through the whole docs, document by document. If you are interested, we can join our forces.

@DevSpace88
Copy link

I will from now on post here before I start a new translation. I would be grateful if others could do so too, so that this does not happen anymore.

Sounds like a good idea. I will do the same then.

Copy link
Contributor

@GeorchW GeorchW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nett!

Zwei Dinge, die sich durch den Text durchziehen:

  1. Ich würde etwas weniger aggressiv eindeutschen. Z.B. die Übersetzungen "performance" => "Performanz" und "client" => "Klient" lassen einen als Deutschen eher stolpern. Ich bin mir recht sicher, dass ich in deutschsprachigen IT-Magazinen auch keine Übersetzungen dafür finden würde.
  2. Komposita werden im Deutschen grundsΓ€tzlich nicht mit Leerzeichen geschrieben, sondern entweder am StΓΌck oder mit Bindestrich, z.B. "Pfad-Parameter" oder "Pfadparameter", aber nicht "Pfad Parameter".

docs/de/docs/tutorial/path-params.md Outdated Show resolved Hide resolved
docs/de/docs/tutorial/path-params.md Outdated Show resolved Hide resolved
docs/de/docs/tutorial/path-params.md Outdated Show resolved Hide resolved
docs/de/docs/tutorial/path-params.md Outdated Show resolved Hide resolved
docs/de/docs/tutorial/path-params.md Outdated Show resolved Hide resolved
docs/de/docs/tutorial/path-params.md Outdated Show resolved Hide resolved
docs/de/docs/tutorial/path-params.md Outdated Show resolved Hide resolved
docs/de/docs/tutorial/path-params.md Outdated Show resolved Hide resolved
docs/de/docs/tutorial/path-params.md Show resolved Hide resolved
docs/de/docs/tutorial/path-params.md Outdated Show resolved Hide resolved
nilslindemann and others added 9 commits September 21, 2023 12:18
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
@tiangolo
Copy link
Owner

πŸ“ Docs preview for commit 3495486 at: https://09da0811.fastapitiangolo.pages.dev

@nilslindemann
Copy link
Contributor Author

nilslindemann commented Sep 21, 2023

Hallo @GeorchW,

Danke fΓΌr deine vielen guten VorschlΓ€ge.

  1. Komposita werden im Deutschen grundsΓ€tzlich nicht mit Leerzeichen geschrieben, sondern entweder am StΓΌck oder mit Bindestrich, z.B. "Pfad-Parameter" oder "Pfadparameter", aber nicht "Pfad Parameter".

Da stimme ich zu. Allerdings scheint das seit der neuen Rechtschreibung optional zu sein, zumindest hat LanguageTool nicht genârgelt. Deswegen ist es mir auch bei der Rechtschreibprüfung durch die Finger geflutscht. In spÀteren Übersetzungen verwende ich, wenn mâglich (hoffentlich) den Bindestrich. Danke für diese Korrekturen.

  1. Ich würde etwas weniger aggressiv eindeutschen. Z.B. die Übersetzungen "performance" => "Performanz" und "client" => "Klient" lassen einen als Deutschen eher stolpern. Ich bin mir recht sicher, dass ich in deutschsprachigen IT-Magazinen auch keine Übersetzungen dafür finden würde.

Ja, das ist ein schwieriges Problem, was übersetzen und was nicht. Ich übersetze mittlerweile auch weniger (beispielsweise belasse ich "Request-Body" und "Response-Body") und füge notfalls eine deutsche Übersetzung in Klammern oder als Hover-Info hinzu. Bin hier wohl zu weit gegangen.

nilslindemann and others added 5 commits September 21, 2023 12:55
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
@tiangolo
Copy link
Owner

πŸ“ Docs preview for commit f6568fd at: https://5c7ba67e.fastapitiangolo.pages.dev

nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Nov 2, 2023
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Nov 2, 2023
@tiangolo
Copy link
Owner

πŸ“ Docs preview for commit a76dd13 at: https://221f9127.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

πŸ“ Docs preview for commit 3be35d9 at: https://c226d385.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

πŸ“ Docs preview for commit 3fb48dc at: https://0476f9e5.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

πŸ“ Docs preview for commit 630af03 at: https://d1445229.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

πŸ“ Docs preview for commit 113fc56 at: https://4084d537.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

tiangolo commented Dec 1, 2023

πŸ“ Docs preview for commit 544c480 at: https://32e4c656.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

πŸ“ Docs preview for commit 75ec88d at: https://9e8ecea4.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

πŸ“ Docs preview for commit efce289 at: https://afc4db35.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

πŸ“ Docs preview for commit a1948e3 at: https://6e8e3427.fastapitiangolo.pages.dev

Copy link

@mattkoehne mattkoehne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work! πŸ₯‡


## Daten-<abbr title="Auch bekannt als: Serialisierung, Parsen, Marshalling">Konversion</abbr>

Wenn Sie dieses Beispiel ausfΓΌhren und Ihren Browser unter <a href="http://127.0.0.1:8000/items/3" class="external-link" target="_blank">http://127.0.0.1:8000/items/3</a> ΓΆffnen, sehen Sie als Response:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more readable would be something like Wenn Sie jetzt z.B. in Ihrem Browser die Adresse ... aufrufen, erhalten Sie als Response: but your sentence is fine :)


Indem Sie von `str` erben, weiß die API Dokumentation, dass die Werte des Enums vom Typ `str` sein müssen, und wird in der Lage sein, korrekt zu rendern.

Erstellen Sie dann Klassen-Attribute mit festgelegten Werten, welches die erlaubten Werte sein werden:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welches -> welche


### Testen Sie es in der API-Dokumentation

Weil die erlaubten Werte fΓΌr den *Pfad-Parameter* nun vordefiniert sind, kann die interaktive Dokumentation sie als Auswahl-Drop-Down anzeigen:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the common german word is Dropdown-MenΓΌ instead of Auswahl-Drop-Down.

@alejsdev alejsdev requested a review from GeorchW January 25, 2024 19:18
@tiangolo tiangolo merged commit ffabc36 into tiangolo:master Mar 30, 2024
35 checks passed
@tiangolo
Copy link
Owner

Awesome @nilslindemann! πŸš€

As you are the champion of German translations and you have done so many, and with so much attention to detail, I'm gonna go ahead and merge this. πŸŽ‰

If others see things that could be improved later, we can check that in new PRs. πŸ€“

@nilslindemann
Copy link
Contributor Author

Thanks a ton @tiangolo for your trust. This simplifies things a lot and helps clear your and my backlog. This comment also goes to all the other merged PRs (I hope you inserted this comment using a script XD)

@mattkoehne Sorry, anyhow I overlooked your review comments in this PR, they were from January :-O. Well, now it's merged. Will later create a PR which applies them. Thanks for your many reviews, including this one.

@nilslindemann nilslindemann deleted the de/docs/tutorial/path-params.md branch April 1, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-all Translations lang-de German translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants