Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Review and rewording of en/docs/contributing.md #10480

Merged
merged 30 commits into from Jan 11, 2024

Conversation

nilslindemann
Copy link
Contributor

@nilslindemann nilslindemann commented Oct 19, 2023

  • Explain more detailed how to translate links (#hash-parts!). Explain a few other things, like not to translate !!! note, etc.
  • Remove some redundacies and restructure some headings.
  • Improve venv setup instructions.

This PR does not break markdown files linking to it.

#10487 is a translation of this.

@nilslindemann nilslindemann changed the title Review en/docs/contributing.md Review en/docs/contributing.md Oct 19, 2023
@tiangolo
Copy link
Owner

📝 Docs preview for commit 129e701 at: https://8b61a07a.fastapitiangolo.pages.dev

@nilslindemann nilslindemann changed the title Review en/docs/contributing.md Review of en/docs/contributing.md Oct 19, 2023
@tiangolo
Copy link
Owner

📝 Docs preview for commit e56d9b2 at: https://2bc59bfa.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

📝 Docs preview for commit ce8df22 at: https://a744d637.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

📝 Docs preview for commit 891ca8b at: https://97fd03ad.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

📝 Docs preview for commit 9fcacee at: https://2582cf28.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

📝 Docs preview for commit c6f38a0 at: https://e6f04daa.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

📝 Docs preview for commit 2dfc8cd at: https://3ca71f01.fastapitiangolo.pages.dev

nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Oct 20, 2023
* Full translation
* In sync with tiangolo#10480, which is a review of docs/en/docs/contributing.md
* Google Translate used
* Manually checked
* Checked for errors using LanguageTool
And simplify search term
@tiangolo
Copy link
Owner

📝 Docs preview for commit 3f54fb9 at: https://4c71ea3d.fastapitiangolo.pages.dev

@tiangolo tiangolo added the docs Documentation about how to use FastAPI label Oct 29, 2023
@tiangolo tiangolo changed the title Review of en/docs/contributing.md 📝 Review and rewording of en/docs/contributing.md Oct 29, 2023
@tiangolo
Copy link
Owner

📝 Docs preview for commit 8d332ac at: https://f445fcb7.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

📝 Docs preview for commit 86b73e0 at: https://7dc8f815.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

📝 Docs preview for commit b8f5057 at: https://28622332.fastapitiangolo.pages.dev

nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Nov 2, 2023
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Nov 2, 2023
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Nov 3, 2023
@tiangolo
Copy link
Owner

📝 Docs preview for commit b7a9dd5 at: https://1aac5feb.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

tiangolo commented Dec 1, 2023

📝 Docs preview for commit f36b0e9 at: https://d219f92a.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

📝 Docs preview for commit 6aba798 at: https://710b5b26.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

tiangolo commented Jan 11, 2024

Amazing job (as always) @nilslindemann! Thank you! ☕ 🍪 🍪 (double cookie for you)

I just tweaked the format of one link, this is ready. 🚀

@tiangolo tiangolo enabled auto-merge (squash) January 11, 2024 17:37
@tiangolo tiangolo merged commit 0380ca3 into tiangolo:master Jan 11, 2024
39 checks passed
@nilslindemann
Copy link
Contributor Author

Thank you @tiangolo. Was away a few days, checking the backlog now XD

@nilslindemann nilslindemann deleted the review-en/docs/contributing.md branch January 13, 2024 08:46
@tiangolo
Copy link
Owner

Thanks for all your help @nilslindemann! Would love to chat with you. 😁

I wrote to your email (the one that appears on GitHub), but if there's any other method feel free to write me an email or anything! 🤓

nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Jan 13, 2024
@nilslindemann
Copy link
Contributor Author

Thanks, @tiangolo, I come back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation about how to use FastAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants