-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Portuguese translation for Tutorial - First Steps #1861
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1861 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 237 239 +2
Lines 7078 7079 +1
=========================================
+ Hits 7078 7079 +1
Continue to review full report at Codecov.
|
📝 Docs preview for commit 13a4ba7 at: https://5f303c36f5cc1f021cffdd46--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be that in the "schema", it would not be the case to put it in italics because it is not a word in Portuguese? Anyway thanks @jessicapaz!
📝 Docs preview for commit 3f88582 at: https://5f306633848de07a2f493835--fastapi.netlify.app |
📝 Docs preview for commit ae4ee5a at: https://5f30744bf5cc1f0512ffdb96--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation is pretty good, thanks. Could you please find my comments?
There are other translated pages that use the verb "Rodar" instead of "Executar" for the verb "run". I would go with "Executar" as you did.
Example: https://github.com/tiangolo/fastapi/blob/master/docs/pt/docs/index.md
Co-authored-by: deniscapeto <deniscapeto@gmail.com>
📝 Docs preview for commit d500a02 at: https://5f7c7e7b5b3f221d9f29868c--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Awesome! Thanks for the contribution @jessicapaz ! 🤓 🚀 🍰 And thanks @Kludex , @cassiobotaro , @deniscapeto for the reviews! 🙇 👏 ☕ |
This PR translates the tutorial/first-steps.md and add this page to the mkdocs.yml file.