Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Portuguese translation for Tutorial - First Steps #1861

Merged
merged 5 commits into from
Oct 17, 2020

Conversation

jessicapaz
Copy link
Contributor

This PR translates the tutorial/first-steps.md and add this page to the mkdocs.yml file.

@codecov
Copy link

codecov bot commented Aug 9, 2020

Codecov Report

Merging #1861 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1861   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          237       239    +2     
  Lines         7078      7079    +1     
=========================================
+ Hits          7078      7079    +1     
Impacted Files Coverage Δ
fastapi/params.py 100.00% <0.00%> (ø)
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/encoders.py 100.00% <0.00%> (ø)
fastapi/requests.py 100.00% <0.00%> (ø)
fastapi/exceptions.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
fastapi/openapi/utils.py 100.00% <0.00%> (ø)
fastapi/openapi/models.py 100.00% <0.00%> (ø)
fastapi/dependencies/utils.py 100.00% <0.00%> (ø)
fastapi/dependencies/models.py 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad7c55...d500a02. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2020

📝 Docs preview for commit 13a4ba7 at: https://5f303c36f5cc1f021cffdd46--fastapi.netlify.app

Copy link
Contributor

@cassiobotaro cassiobotaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be that in the "schema", it would not be the case to put it in italics because it is not a word in Portuguese? Anyway thanks @jessicapaz!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2020

📝 Docs preview for commit 3f88582 at: https://5f306633848de07a2f493835--fastapi.netlify.app

docs/pt/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/pt/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2020

📝 Docs preview for commit ae4ee5a at: https://5f30744bf5cc1f0512ffdb96--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-pt Portuguese translations labels Aug 16, 2020
Copy link
Contributor

@deniscapeto deniscapeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation is pretty good, thanks. Could you please find my comments?

There are other translated pages that use the verb "Rodar" instead of "Executar" for the verb "run". I would go with "Executar" as you did.

Example: https://github.com/tiangolo/fastapi/blob/master/docs/pt/docs/index.md

docs/pt/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/pt/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/pt/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
Co-authored-by: deniscapeto <deniscapeto@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2020

📝 Docs preview for commit d500a02 at: https://5f7c7e7b5b3f221d9f29868c--fastapi.netlify.app

Copy link
Contributor

@deniscapeto deniscapeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiangolo tiangolo changed the title Portuguese translation for the tutorial/first-steps page 🌐 Add Portuguese translation for Tutorial - First Steps Oct 17, 2020
@tiangolo tiangolo merged commit 78ead58 into fastapi:master Oct 17, 2020
@tiangolo
Copy link
Member

Awesome! Thanks for the contribution @jessicapaz ! 🤓 🚀 🍰

And thanks @Kludex , @cassiobotaro , @deniscapeto for the reviews! 🙇 👏 ☕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-pt Portuguese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants