Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Japanese translation for docs/ja/docs/tutorial/body-nested-models.md #1930

Merged
merged 20 commits into from Jan 15, 2024
Merged

🌐 Add Japanese translation for docs/ja/docs/tutorial/body-nested-models.md #1930

merged 20 commits into from Jan 15, 2024
+244 −0

Conversation

SwftAlpc
Copy link
Contributor

@SwftAlpc SwftAlpc commented Aug 20, 2020 •
edited

This PR translates the tutorial/body-nested-models.md to Japanese.
Please review tutorial/body-nested-models.md

Issue #1571 generates a new directory to support Japanese.
PR #1656 generates a new directory for tutorial.
I will fix dependency after #1571 & #1656 are merged.

@SwftAlpc SwftAlpc mentioned this pull request Aug 20, 2020
Closed
@codecov
Copy link

codecov bot commented Aug 20, 2020 •
edited

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf73051) 100.00% compared to head (1e2066b) 100.00%.

❗ Current head 1e2066b differs from pull request most recent head 0ad805d. Consider uploading reports for the commit 0ad805d to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##            master     #1930     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       239    -301     
  Lines        13969      7079   -6890     
===========================================
- Hits         13969      7079   -6890

see 356 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 1078566 at: https://5f3e9289fe514400e681a77e--fastapi.netlify.app

tokusumi
tokusumi reviewed Aug 21, 2020
View reviewed changes
docs/ja/docs/tutorial/body-nested-models.md Outdated
Comment on lines 15 to 17
## サブタイプを持つリストのフィールド

しかし、Pythonにはサブタイプを使ってリストを宣言する方法があります:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

タイプパラメータを持つリストのフィールド

しかし、Pythonには型や「タイプパラメータ」を使ってリストを宣言する方法があります:
(this sentences is updated)

docs/ja/docs/tutorial/body-nested-models.md Outdated
{!../../../docs_src/body_nested_models/tutorial002.py!}
```

### サブタイプを持つ`List`の宣言
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is updated. Could you check it and translate the latest document?

docs/ja/docs/tutorial/body-nested-models.md Outdated
{!../../../docs_src/body_nested_models/tutorial004.py!}
```

### サブモデルの型として使用
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

サブモデルを型として使用

docs/ja/docs/tutorial/body-nested-models.md Outdated
Comment on lines 110 to 112
繰り返しになりますが、**FastAPI** を使用して、その宣言を行うだけで以下のようになります:

* 入れ子になったモデルでもエディタのサポート（補完など）
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

繰り返しになりますが、FastAPI を使用して、その宣言を行うだけで以下のような恩恵を受けられます:

  • 入れ子になったモデルでも対応可能なエディタのサポート（補完など）

@SwftAlpc
Copy link
Contributor Author

@tokusumi
Thanks for review! I fixed it. Please re-review!

@github-actions
Copy link
Contributor

📝 Docs preview for commit 275448c at: https://5f41609c560aaa7ce9e6460c--fastapi.netlify.app

tokusumi
tokusumi approved these changes Aug 22, 2020
View reviewed changes
Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LSTM!

you translate "nested" with "入れ子", on the other hand, I did it with "ネストされた" in other section. I can accept both of them with no changes.

might you want to unify them?

@SwftAlpc
Copy link
Contributor Author

@tokusumi
Ah, I see.
Since "ネストされた" sounds more familiar to developers, let's unify it with "ネストされた".

@github-actions
Copy link
Contributor

📝 Docs preview for commit 3f4a7e9 at: https://5f42257e618e31a970a4bc14--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Aug 29, 2020
@github-actions
Copy link
Contributor

📝 Docs preview for commit be325fa at: https://5f4cbfa6302549e185748a81--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 1e2066b at: https://5f9aa30eefcb983ab7c4299a--fastapi.netlify.app

@tiangolo tiangolo changed the title Add tutorial/body-nested-models.md Japanese ver 🌐 Add Japanese translation for docs/ja/docs/tutorial/body-nested-models.md Jun 26, 2023
@tiangolo tiangolo added lang-ja Japanese translations awaiting-review and removed lang-ja Japanese translations awaiting-review labels Jun 26, 2023
@tiangolo
Copy link
Owner

📝 Docs preview for commit 0ad805d at: https://6499c185c77ce600c0dfd6dd--fastapi.netlify.app

@tiangolo
Copy link
Owner

As this was done by @SwftAlpc and reviewed by @tokusumi, champions of the Japanese translations, I'm gonna merge this. 🚀

@tiangolo tiangolo merged commit 88f19be into tiangolo:master Jan 15, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokusumi tokusumi tokusumi approved these changes

Assignees
No one assigned
Labels
awaiting-review lang-all Translations lang-ja Japanese translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SwftAlpc @tiangolo @tokusumi @ryuckel