Fix using websockets with prefixed routers #3735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this fix. Thanks |
|
Also ran into this issue today. Glad to see someone else has already looked at it! |
|
@tiangolo pls |
yezz123
approved these changes
Apr 8, 2022
BilalAlpaslan
approved these changes
Apr 8, 2022
|
Thanks for your work @chrisburr! This was included in #2640, it will be available in FastAPI version Given that, I'll close this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the newly reported issues in #98 with router prefixes being ignored and improves the tests to explicitly check for this.