Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Korean translation for docs/ko/docs/async.md #4179

Merged
merged 5 commits into from Jul 27, 2023
Merged

🌐 Add Korean translation for docs/ko/docs/async.md #4179

merged 5 commits into from Jul 27, 2023

Conversation

NinaHwang
Copy link
Contributor

This is a quite advanced topic, so I'm afraid there might be some mistakes.
I appreciate your feedbacks. Thank you🤗

related: #2017

@NinaHwang NinaHwang changed the title 🌐 Add Korean translation for docs/async.md 🌐 Add Korean translation for docs/async.md Nov 16, 2021
@codecov
Copy link

codecov bot commented Nov 16, 2021 •
edited

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf73051) 100.00% compared to head (cd82a33) 100.00%.

❗ Current head cd82a33 differs from pull request most recent head ebea419. Consider uploading reports for the commit ebea419 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##            master     #4179     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       409    -131     
  Lines        13969     10264   -3705     
===========================================
- Hits         13969     10264   -3705

see 177 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 8fafecd at: https://61933d069d124119a80f9642--fastapi.netlify.app

DevDae
DevDae reviewed Nov 17, 2021
View reviewed changes
Copy link
Contributor

@DevDae DevDae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your works! 🚀
It's so easy to understand the notion of "asyn" in your Korean translation!

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Dec 8, 2021
@github-actions github-actions bot mentioned this pull request Dec 8, 2021
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

📝 Docs preview for commit a760952 at: https://61b152407675788c5485e7cf--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

📝 Docs preview for commit cd82a33 at: https://61b21343455d75586f5c2386--fastapi.netlify.app

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@joonas-yoon
translated by tiangolo#4179
194f00c
@NinaHwang NinaHwang requested a review from DevDae January 30, 2023 06:46
@tiangolo
Copy link
Owner

📝 Docs preview for commit ebea419 at: https://649a1e8cce5a760f07de105a--fastapi.netlify.app

@tiangolo tiangolo changed the title 🌐 Add Korean translation for docs/async.md 🌐 Add Korean translation for docs/ko/docs/async.md Jun 27, 2023
@JeongHyeongKim
Copy link
Contributor

great work :)

@tiangolo
Copy link
Owner

Nice, thanks @NinaHwang! 🚀

And thanks for the reviews @JeongHyeongKim, @kty4119, @DevDae 🎉

@tiangolo tiangolo merged commit 5587103 into tiangolo:master Jul 27, 2023
31 checks passed
erosennin pushed a commit to erosennin/fastapi that referenced this pull request Jul 31, 2023
@NinaHwang @tiangolo
@pre-commit-ci @erosennin
🌐 Add Korean translation for docs/ko/docs/async.md (tiangolo#4179)
6f0b099 
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeongHyeongKim JeongHyeongKim JeongHyeongKim approved these changes

@kty4119 kty4119 kty4119 approved these changes

@DevDae DevDae Awaiting requested review from DevDae

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-ko Korean translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@NinaHwang @tiangolo @JeongHyeongKim @kty4119 @DevDae