Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Korean translation for docs/ko/docs/deployment/server-workers.md #4935

Merged

Conversation

jujumilk3
Copy link
Contributor

Translates docs/ko/docs/deployment/server-workers.md and add deploy menu in Korean.
related: #2017

@codecov
Copy link

codecov bot commented May 22, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf73051) 100.00% compared to head (0f6a72d) 100.00%.
Report is 1086 commits behind head on master.

❗ Current head 0f6a72d differs from pull request most recent head 3baea96. Consider uploading reports for the commit 3baea96 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #4935    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          540       532     -8     
  Lines        13969     13684   -285     
==========================================
- Hits         13969     13684   -285     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

📝 Docs preview for commit ca61b77 at: https://6289c940a700c11725e7fefa--fastapi.netlify.app

@tiangolo tiangolo added lang-all Translations awaiting-review lang-ko Korean translations labels Jul 14, 2022
@github-actions github-actions bot mentioned this pull request Jul 14, 2022
Copy link
Sponsor Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned at #3167 (reply in thread),
"구니콘" is more proper than "규니콘"

@jujumilk3 jujumilk3 force-pushed the translation/deployment/server-workers branch from ca61b77 to 3eab4ca Compare July 20, 2022 16:19
@github-actions
Copy link
Contributor

📝 Docs preview for commit 8fb6749 at: https://62d82c1067dd2e14860a7859--fastapi.netlify.app

@jujumilk3 jujumilk3 force-pushed the translation/deployment/server-workers branch from 8fb6749 to 084855f Compare July 20, 2022 16:28
@jujumilk3 jujumilk3 force-pushed the translation/deployment/server-workers branch from 084855f to 0f6a72d Compare July 20, 2022 16:31
@github-actions
Copy link
Contributor

📝 Docs preview for commit 0f6a72d at: https://62d82ea4be519300682cf54d--fastapi.netlify.app

Copy link
Sponsor Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@github-actions
Copy link
Contributor

📝 Docs preview for commit 89d1981 at: https://63c6d37dac642e62ec5f40c3--fastapi.netlify.app

@tiangolo
Copy link
Owner

📝 Docs preview for commit 3baea96 at: https://649a1d12cc19e515a6cacf72--fastapi.netlify.app

@alejsdev alejsdev merged commit 79ab317 into tiangolo:master Jan 22, 2024
32 checks passed
@alejsdev
Copy link
Collaborator

Thank you! @jujumilk3 😄

And thanks for the review @hard-coders 🔍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-1 lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants