Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hierarchical scope propagation #5624

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Fix hierarchical scope propagation #5624

wants to merge 11 commits into from

Conversation

kristjanvalur
Copy link
Contributor

see defect #5623

@kristjanvalur kristjanvalur mentioned this pull request Nov 11, 2022
Closed
9 tasks
@github-actions
Copy link
Contributor

📝 Docs preview for commit 2e47883 at: https://636e6305e364640052938cb0--fastapi.netlify.app

@kristjanvalur kristjanvalur marked this pull request as ready for review November 11, 2022 15:02
kristjanvalur added a commit to kristjanvalur/fastapi that referenced this pull request Nov 12, 2022
@kristjanvalur
Add scope inheritance fix from pr tiangolo#5624
b8e8f9e
kristjanvalur added a commit to kristjanvalur/fastapi that referenced this pull request Nov 22, 2022
@kristjanvalur
Add scope inheritance fix from pr tiangolo#5624
8b19290
@github-actions
Copy link
Contributor

📝 Docs preview for commit f9cc738 at: https://637e3f58cb239205d8f8ac46--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit ed31809 at: https://638366ab3f0ba6730f1922f5--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 03b718a at: https://638370461f56596d908789a9--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit a7cfa5c at: https://639ce7aaf6c0690692abeade--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 992477d at: https://639eee3efceb14627ea7fa75--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 0872506 at: https://63bfdfc103b01012669526df--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2023

📝 Docs preview for commit 21ad285 at: https://64046bd7dccd427bd7b12613--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

📝 Docs preview for commit bf72d40 at: https://6457875e338faa54d752939e--fastapi.netlify.app

@tiangolo
Copy link
Owner

📝 Docs preview for commit 6f47a37 at: https://648d7c02c41d51697f59ba41--fastapi.netlify.app

@tiangolo tiangolo added the bug Something isn't working label Oct 2, 2023
@alejsdev alejsdev added p3 and removed investigate labels Jan 15, 2024
YuriiMotov
YuriiMotov approved these changes Feb 29, 2024
View reviewed changes
Copy link

@YuriiMotov YuriiMotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue is relevant to FastAPI 0.110.0.
The test fails before the changes are made and passes after.
Code is nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriiMotov YuriiMotov YuriiMotov approved these changes

Assignees
No one assigned
Labels
bug Something isn't working p3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kristjanvalur @tiangolo @YuriiMotov @alejsdev