Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Korean translation for docs/ko/docs/tutorial/background-tasks.md #5910

Merged
merged 17 commits into from Jan 27, 2024
Merged

Conversation

junah201
Copy link
Contributor

@junah201 junah201 commented Jan 21, 2023

@github-actions
Copy link
Contributor

📝 Docs preview for commit 41765e8 at: https://63cbfdf34399b90fa88a39be--fastapi.netlify.app

Copy link
Contributor

@joonas-yoon joonas-yoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work :) I commented a little bit.

docs/ko/docs/tutorial/background-tasks.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/background-tasks.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/background-tasks.md Outdated Show resolved Hide resolved
junah201 and others added 2 commits January 22, 2023 18:27
Co-authored-by: Joona Yoon <joonas-yoon@users.noreply.github.com>
Co-authored-by: Joona Yoon <joonas-yoon@users.noreply.github.com>
@github-actions
Copy link
Contributor

📝 Docs preview for commit 930d363 at: https://63cd0258c2544267aa25507e--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 4f4d714 at: https://63cd0cb6c254426fe1254d08--fastapi.netlify.app

docs/ko/docs/tutorial/background-tasks.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/background-tasks.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/background-tasks.md Outdated Show resolved Hide resolved
junah201 and others added 3 commits January 22, 2023 20:16
Co-authored-by: Joona Yoon <joonas-yoon@users.noreply.github.com>
Co-authored-by: Joona Yoon <joonas-yoon@users.noreply.github.com>
Co-authored-by: Joona Yoon <joonas-yoon@users.noreply.github.com>
@github-actions
Copy link
Contributor

📝 Docs preview for commit a302613 at: https://63cd1bfb5efb247de1e902a1--fastapi.netlify.app

@tiangolo tiangolo changed the title Add Korean translation for docs/ko/docs/tutorial/background-tasks.md 🌐 Add Korean translation for docs/ko/docs/tutorial/background-tasks.md Feb 7, 2023
@tiangolo tiangolo added lang-all Translations awaiting-review lang-ko Korean translations labels Feb 7, 2023
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Copy link
Contributor Author

@junah201 junah201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor fixes

docs/ko/docs/tutorial/background-tasks.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/background-tasks.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/background-tasks.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/background-tasks.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

📝 Docs preview for commit f5db5cd at: https://63ee67b9d599a13ca399ddd3--fastapi.netlify.app

@tiangolo
Copy link
Owner

📝 Docs preview for commit e3284b4 at: https://649a1e92acd72b160761e973--fastapi.netlify.app

Copy link

@Junhyung21 Junhyung21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I corrected some grammatical errors and awkward parts.

약간의 문법 오류 및 어색한 부분을 수정하였습니다.

docs/ko/docs/tutorial/background-tasks.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/background-tasks.md Outdated Show resolved Hide resolved
junah201 and others added 4 commits June 30, 2023 21:23
Co-authored-by: 김준형 <138214497+Junhyung21@users.noreply.github.com>
Co-authored-by: 김준형 <138214497+Junhyung21@users.noreply.github.com>
Co-authored-by: 김준형 <138214497+Junhyung21@users.noreply.github.com>
Co-authored-by: 김준형 <138214497+Junhyung21@users.noreply.github.com>
Copy link

@Junhyung21 Junhyung21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve !

@alejsdev alejsdev merged commit 3817514 into tiangolo:master Jan 27, 2024
41 checks passed
@alejsdev
Copy link
Collaborator

Thank you! @junah201 🚀

And thanks for the reviews @joonas-yoon and @Junhyung21 🧐🔍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-1 lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants