Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump probot from 9.14.1 to 10.1.1 #50

Merged
merged 8 commits into from
Sep 2, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Sep 1, 2020

Bumps probot from 9.14.1 to 10.1.1.

Release notes

Sourced from probot's releases.

v10.1.1

v10 release notes

This is the first stable release for v10. See all breaking changes and new features at https://github.com/probot/probot/releases/edit/v10.0.0

Bug Fixes

  • app.auth(installationId) returns octokit instance with all required installation authentication settings (#1326) (410302f)

v10.1.0

10.1.0 (2020-08-28)

Features

v10.0.1

Bug Fixes

  • throttleOption defaults and REDIS_URL configuration (#1313) (84d4371)

v10.0.0

Breaking changes

  • @octokit/rest has been updated from v16 to v17. See release notes. Important: If you currently mocked context.github.* methods in your test, replace these with http mocks using nock instead, otherwise your tests will create methods that no longer exist and you will see errors in production although your tests passed. See wip/app#238 for an example

  • URL parameters are now always encoded when using context.github.* methods. For example, if you use context.github.repos.getContent( owner, repo, path ) make sure to not encode the value for path. Also if you were mocking http requests in your tests, replace e.g. repos/octocat/hello-world/contents/.github/config.yml with repos/octocat/hello-world/contents/.github%2Fconfig.yml

  • require Node 10.21+

  • The logging output changed. Before, probot used bunyan with all kind of hacks and customizations for its log output. Now we use pino. We still do the formatting and sending errors to Sentry in the same process, but the logic is now encapsulated in @probot/pino. We might decouple it in future as part of making Probot more suitable for serverless/function environments

  • context.issue() now returns .issue_number instead of .number. Use context.pullRequest() for octokit.pulls.* method calls.

  • registry_package event was renamed to package

  • The probot package no longer exports Octokit. Use ProbotOctokit instead.

    const { ProbotOctokit, ProbotOctokitCore } = require('probot')
  • Probot no longer accepts options.throttlingOptions. In order to disable throttling for testing, set options.Octokit to ProbotOctokit.defaults({ retry: { enabled: false }, throttle: { enabled: false } }):

    const { Probot, ProbotOctokit } = require('probot')
    const probot = new Probot({
    Octokit: ProbotOctokit.defaults({ retry: { enabled: false }, throttle: { enabled: false } })

Commits
  • db03885 fix: app.auth(installationId) returns octokit instance with all required ...
  • 5dcb8ae feat: log Probot version at startup (#1321)
  • 8b07e38 build(package): remove broken start script from package.json (#1320)
  • ca07116 docs(pagination): use correct endpoint method
  • c439103 fix: throttleOption defaults and REDIS_URL configuration (#1313)
  • ad32164 test(deprecation): octokit.repos.createStatus()
  • 072b8c2 v10.0.0
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

closes #51

@vercel
Copy link

vercel bot commented Sep 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tianhaoz95/approveman-api-docs/5glczuzyi
✅ Preview: https://approveman-api-docs-git-dependabot-npmandyarnprobot-1011.tianhaoz95.vercel.app

@tianhaoz95
Copy link
Owner

@dependabot rebase

@tianhaoz95 tianhaoz95 removed the major Major version label Sep 1, 2020
Bumps [probot](https://github.com/probot/probot) from 9.14.1 to 10.1.1.
- [Release notes](https://github.com/probot/probot/releases)
- [Commits](probot/probot@v9.14.1...v10.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@tianhaoz95
Copy link
Owner

Fix the Octokit type importing from probot. It seems that they refactored the exporting in this version. Should probably import from octokit itself.

@tianhaoz95 tianhaoz95 changed the title chore(deps): bump probot from 9.14.1 to 10.1.1 chore(deps): bump probot from 9.14.1 to 10.1.1 (wip) Sep 2, 2020
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #50 into master will increase coverage by 0.67%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   90.72%   91.39%   +0.67%     
==========================================
  Files           7        7              
  Lines         194      186       -8     
  Branches       29       31       +2     
==========================================
- Hits          176      170       -6     
  Misses          7        7              
+ Partials       11        9       -2     
Impacted Files Coverage Δ
src/index.ts 100.00% <ø> (ø)
src/utils/config_parser/default.ts 100.00% <ø> (ø)
src/core/index.ts 87.36% <82.35%> (-2.93%) ⬇️
src/utils/config_parser/index.ts 82.60% <100.00%> (+17.39%) ⬆️
src/utils/rule_matcher/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d6712...989dab5. Read the comment docs.

@tianhaoz95 tianhaoz95 changed the title chore(deps): bump probot from 9.14.1 to 10.1.1 (wip) chore(deps): bump probot from 9.14.1 to 10.1.1 Sep 2, 2020
@tianhaoz95 tianhaoz95 added minor Minor version and removed patch Patch version labels Sep 2, 2020
@dependabot-preview
Copy link
Contributor Author

A newer version of probot exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Copy link
Owner

Codacy Here is an overview of what got changed by this pull request:

Coverage decreased per file
===========================
- src/core/index.ts  -1
         

See the complete overview on Codacy

@tianhaoz95 tianhaoz95 merged commit bc0e952 into master Sep 2, 2020
@tianhaoz95 tianhaoz95 deleted the dependabot/npm_and_yarn/probot-10.1.1 branch September 2, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated dependency update For dependabot minor Minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the Octokit type importing from probot
1 participant