-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
locate_tools: add detailed warnings for vcvarsall.bat errors #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdaed74
to
b153d2e
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #320 +/- ##
==========================================
+ Coverage 78.75% 78.79% +0.03%
==========================================
Files 47 47
Lines 6703 6710 +7
==========================================
+ Hits 5279 5287 +8
+ Misses 1424 1423 -1
☔ View full report in Codecov by Sentry. |
b153d2e
to
5a4cd83
Compare
makubacki
reviewed
May 11, 2023
5a4cd83
to
76601da
Compare
…pytool-library into path-len-warning
Flickdm
reviewed
May 25, 2023
Flickdm
approved these changes
May 25, 2023
makubacki
reviewed
May 25, 2023
makubacki
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional logging to
QueryVcVariables()
when calling vcvarsall.bat. command prompt arguments are limited to 8191 characters, which includes ENV variables. On top of that, any ENV variable that exceeds 8191 characters itself is not passed to a command.This causes two different errors when confusing:
When the total env is greater than 8191 characters (but a specific variable is not), the command fails with an ambigious error
Exception: The input line is too long. The syntax of the command is incorrect.
When a specific variable is greater than 8191 characters (commonly the PATH variable), it is not passed to the command. This means that the command does not fail, however specifically for vcvarsall.bat, we might fail to find what we are searching for because the folder it resides in could set in PATH.
This commit adds the following: