shifting a negative signed value is undefined

[lersek]

@ajfish

cloned from #30 (comment)

It is compiler defined behavior in the older world, and that is why clang has added the warning. I also see the error in the base Tools as it has a case of shifting -1.

https://github.com/tianocore/edk2/blob/master/BaseTools/Source/C/Common/FvLib.c

//
// Get next file, compensate for 8 byte alignment if necessary.
//
*NextFile = (EFI_FFS_FILE_HEADER *) ((((UINTN) CurrentFile - (UINTN) mFvHeader + GetFfsFileLength(CurrentFile) + 0x07) & (-1 << 3)) + (UINT8 *) mFvHeader);

[lersek]

Patch on list:
http://thread.gmane.org/gmane.comp.bios.edk2.devel/12270

[ajfish]

Thanks,

Andrew Fish

On May 17, 2016, at 6:55 PM, Liming Gao notifications@github.com wrote:

Closed #49 #49 via d3bb711 d3bb711.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub #49 (comment)