Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConvertMasmToNasm.py requires a git tree #63

Closed
jljusten opened this issue Mar 3, 2016 · 0 comments
Closed

ConvertMasmToNasm.py requires a git tree #63

jljusten opened this issue Mar 3, 2016 · 0 comments
Assignees
@jljusten

Comments

@jljusten
Copy link
Member

jljusten commented Mar 3, 2016

If the script is run outside of a git tree, this is the result:

edk2/BaseTools/Scripts/ConvertMasmToNasm.py Version 0.01
Traceback (most recent call last):
  File "edk2/BaseTools/Scripts/ConvertMasmToNasm.py", line 986, in <module>
    ConvertAsmApp()
  File "edk2/BaseTools/Scripts/ConvertMasmToNasm.py", line 984, in __init__
    ConvertAsmFile(src, dst, self)
  File "edk2/BaseTools/Scripts/ConvertMasmToNasm.py", line 209, in __init__
    CommonUtils.__init__(self, clone)
  File "edk2/BaseTools/Scripts/ConvertMasmToNasm.py", line 69, in __init__
    self.gitemail = clone.gitemail
AttributeError: ConvertAsmApp instance has no attribute 'gitemail'
@jljusten jljusten self-assigned this Mar 3, 2016
hwu25 pushed a commit that referenced this issue Mar 15, 2016
@jljusten2 @hwu25
BaseTools ConvertMasmToNasm: Fix running script outside of a git tree
2da7e79 
The script previously would hit an exception if it was run outside of
a git tree.

The exception looked like:

edk2/BaseTools/Scripts/ConvertMasmToNasm.py Version 0.01
Traceback (most recent call last):
  File "edk2/BaseTools/Scripts/ConvertMasmToNasm.py", line 986, in <module>
    ConvertAsmApp()
  File "edk2/BaseTools/Scripts/ConvertMasmToNasm.py", line 984, in __init__
    ConvertAsmFile(src, dst, self)
  File "edk2/BaseTools/Scripts/ConvertMasmToNasm.py", line 209, in __init__
    CommonUtils.__init__(self, clone)
  File "edk2/BaseTools/Scripts/ConvertMasmToNasm.py", line 69, in __init__
    self.gitemail = clone.gitemail
AttributeError: ConvertAsmApp instance has no attribute 'gitemail'

Fixes: #63
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
(cherry picked from commit 5369c2b)
gguo11837463 added a commit to gguo11837463/edk2 that referenced this issue Apr 27, 2023
@gguo11837463
.azurepipelines: Choose container that have installed lcov
5da3076 
Azure should install code coverage tool (lcov), it didn't
exist on Fedora and Ubuntu by default.

Update docker setting, pick below solution between 47addc9 and 3b3eb8f
3b3eb8f Fixes and improvements to dev containers (tianocore#69)
54e5bd1 Enable GTK on Fedora QEMU (tianocore#63)
f1c7a20 Fedora: install code coverage tools for GCC (tianocore#62)
2ce82af Ubuntu-22: Add initial Ubuntu-22 image (tianocore#61)
14d2aba Add Fedora 37 image with gcc12 (tianocore#60)
5b8a008 Add dotnet runtime to fedora build (tianocore#57)
f5c874a Fix platform build file name for EDK2 change (tianocore#58)
48540ad Ubuntu-20: Fix dev image entrypoint (tianocore#55)
98e849d Fedora-35: Add Powershell to build image (tianocore#52)

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Oliver Steffen <osteffen@redhat.com>
Cc: Chris Fernald <chfernal@microsoft.com>
Signed-off-by: Gua Guo <gua.guo@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Michael Kubacki <mikuback@linux.microsoft.com>
Reviewed-by: Chris Fernald <chfernal@microsoft.com>
gguo11837463 added a commit to gguo11837463/edk2 that referenced this issue Apr 27, 2023
@gguo11837463
.azurepipelines: Choose container that have installed lcov
cbbffc9 
Azure should install code coverage tool (lcov), it didn't
exist on Fedora and Ubuntu by default.

Update docker setting, pick below solution between 47addc9 and 3b3eb8f
3b3eb8f Fixes and improvements to dev containers (tianocore#69)
54e5bd1 Enable GTK on Fedora QEMU (tianocore#63)
f1c7a20 Fedora: install code coverage tools for GCC (tianocore#62)
2ce82af Ubuntu-22: Add initial Ubuntu-22 image (tianocore#61)
14d2aba Add Fedora 37 image with gcc12 (tianocore#60)
5b8a008 Add dotnet runtime to fedora build (tianocore#57)
f5c874a Fix platform build file name for EDK2 change (tianocore#58)
48540ad Ubuntu-20: Fix dev image entrypoint (tianocore#55)
98e849d Fedora-35: Add Powershell to build image (tianocore#52)

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Oliver Steffen <osteffen@redhat.com>
Cc: Chris Fernald <chfernal@microsoft.com>
Signed-off-by: Gua Guo <gua.guo@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Michael Kubacki <mikuback@linux.microsoft.com>
Reviewed-by: Chris Fernald <chfernal@microsoft.com>
gguo11837463 added a commit to gguo11837463/edk2 that referenced this issue Apr 27, 2023
@gguo11837463
.azurepipelines: Choose container that have installed lcov
0b7449f 
Azure should install code coverage tool (lcov), it didn't
exist on Fedora and Ubuntu by default.

Update docker setting, pick below solution between 47addc9 and 3b3eb8f
3b3eb8f Fixes and improvements to dev containers (tianocore#69)
54e5bd1 Enable GTK on Fedora QEMU (tianocore#63)
f1c7a20 Fedora: install code coverage tools for GCC (tianocore#62)
2ce82af Ubuntu-22: Add initial Ubuntu-22 image (tianocore#61)
14d2aba Add Fedora 37 image with gcc12 (tianocore#60)
5b8a008 Add dotnet runtime to fedora build (tianocore#57)
f5c874a Fix platform build file name for EDK2 change (tianocore#58)
48540ad Ubuntu-20: Fix dev image entrypoint (tianocore#55)
98e849d Fedora-35: Add Powershell to build image (tianocore#52)

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Oliver Steffen <osteffen@redhat.com>
Cc: Chris Fernald <chfernal@microsoft.com>
Signed-off-by: Gua Guo <gua.guo@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Michael Kubacki <mikuback@linux.microsoft.com>
Reviewed-by: Chris Fernald <chfernal@microsoft.com>
mergify bot pushed a commit that referenced this issue Apr 27, 2023
@gguo11837463 @mergify
.azurepipelines: Choose container that have installed lcov
04f8371 
Azure should install code coverage tool (lcov), it didn't
exist on Fedora and Ubuntu by default.

Update docker setting, pick below solution between 47addc9 and 3b3eb8f
3b3eb8f Fixes and improvements to dev containers (#69)
54e5bd1 Enable GTK on Fedora QEMU (#63)
f1c7a20 Fedora: install code coverage tools for GCC (#62)
2ce82af Ubuntu-22: Add initial Ubuntu-22 image (#61)
14d2aba Add Fedora 37 image with gcc12 (#60)
5b8a008 Add dotnet runtime to fedora build (#57)
f5c874a Fix platform build file name for EDK2 change (#58)
48540ad Ubuntu-20: Fix dev image entrypoint (#55)
98e849d Fedora-35: Add Powershell to build image (#52)

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Oliver Steffen <osteffen@redhat.com>
Cc: Chris Fernald <chfernal@microsoft.com>
Signed-off-by: Gua Guo <gua.guo@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Michael Kubacki <mikuback@linux.microsoft.com>
Reviewed-by: Chris Fernald <chfernal@microsoft.com>
MrChromebox pushed a commit to MrChromebox/edk2 that referenced this issue Sep 15, 2023
@gguo11837463 @MrChromebox
.azurepipelines: Choose container that have installed lcov
f2dd35c 
Azure should install code coverage tool (lcov), it didn't
exist on Fedora and Ubuntu by default.

Update docker setting, pick below solution between 47addc9 and 3b3eb8f
3b3eb8f Fixes and improvements to dev containers (tianocore#69)
54e5bd1 Enable GTK on Fedora QEMU (tianocore#63)
f1c7a20 Fedora: install code coverage tools for GCC (tianocore#62)
2ce82af Ubuntu-22: Add initial Ubuntu-22 image (tianocore#61)
14d2aba Add Fedora 37 image with gcc12 (tianocore#60)
5b8a008 Add dotnet runtime to fedora build (tianocore#57)
f5c874a Fix platform build file name for EDK2 change (tianocore#58)
48540ad Ubuntu-20: Fix dev image entrypoint (tianocore#55)
98e849d Fedora-35: Add Powershell to build image (tianocore#52)

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Oliver Steffen <osteffen@redhat.com>
Cc: Chris Fernald <chfernal@microsoft.com>
Signed-off-by: Gua Guo <gua.guo@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Michael Kubacki <mikuback@linux.microsoft.com>
Reviewed-by: Chris Fernald <chfernal@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jljusten jljusten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jljusten