Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aarch64 mmulib #430

Closed
wants to merge 5 commits into from
Closed

Aarch64 mmulib #430

wants to merge 5 commits into from

Conversation

ardbiesheuvel
Copy link
Member

No description provided.

Ard Biesheuvel added 4 commits March 7, 2020 15:05
ArmPkg/ArmMmuLib AARCH64: rewrite page table code
60c3f85 
Replace the slightly overcomplicated page table management code with
a simplified, recursive implementation that should be far easier to
reason about.

Note that, as a side effect, this extends the per-entry cache invalidation
that we do on page table entries to block and page entries, whereas the
previous change inadvertently only affected the creation of table entries.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
ArmPkg/ArmMmuLib AARCH64: invalidate page tables before populating them
553c37e 
As it turns out, ARMv8 also permits accesses made with the MMU and
caches off to hit in the caches, so to ensure that any modifications
we make before enabling the MMU are visible afterwards as well, we
should invalidate page tables right after allocation like we do now on
ARM, if the MMU is still disabled at that point.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
ArmPkg/ArmMmuLib AARCH64: drop pointless page table memory type check
5883dd0 
This is the AARCH64 counterpart of commit 1f3b1eb, to remove
a pointless check against the memory type of the allocations that the
page tables happened to land in. On ArmV8, we use writeback cacheable
attributes exclusively for all memory.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
ArmPkg/ArmMmuLib AARCH64: cosmetic fixups
1ba3cff 
Some cosmetic fixups to the AArch64 MMU code:
- reflow overly long lines unless it hurts legibility
- add/remove whitespace according to the [de facto] coding style
- use camel case for goto labels

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
@ardbiesheuvel ardbiesheuvel added the push Auto push patch series in PR if all checks pass label Mar 7, 2020
@spbrogan
Copy link
Member

spbrogan commented Mar 8, 2020 •
edited

I started a new run of the devops builds to see if mergify would catch the status.

**edit. that didn't help.

@mdkinney
Copy link
Member

mdkinney commented Mar 8, 2020

"@Mergifyio refresh

@mergify
Copy link

mergify bot commented Mar 8, 2020

Command refresh: success

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

20 similar comments
@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@mergify
Copy link

mergify bot commented Mar 8, 2020

PR can not be merged due to a PatchCheck failure. Please resolve and resubmit

@lersek
Copy link
Member

lersek commented Mar 9, 2020

The PatchCheck.py failure is bogus, please see:

https://edk2.groups.io/g/devel/message/55695
http://mid.mail-archive.com/e82e5730-e1c8-0cad-d12d-14d2d47086f8@redhat.com

I'm closing this PR now. I'm going to pick up Ard's patches afresh from the list, along with Leif's R-b's, and then submit a brand new PR.

@lersek lersek closed this Mar 9, 2020
@lersek lersek mentioned this pull request Mar 10, 2020
Merged
@ardbiesheuvel ardbiesheuvel deleted the aarch64-mmulib branch March 26, 2020 08:00
kuqin12 pushed a commit to kuqin12/edk2 that referenced this pull request Oct 3, 2023
@dependabot @makubacki
pip: update edk2-pytool-library requirement from ~=0.15.0 to ~=0.15.2 (…
38f0872 
…tianocore#430)

Updates the requirements on
[edk2-pytool-library](https://github.com/tianocore/edk2-pytool-library)
to permit the latest version.

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ardbiesheuvel @spbrogan @mdkinney @lersek