Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseTools/Plugin: Too many execute file will be failure #4357

Merged
merged 2 commits into from
May 11, 2023

Conversation

gguo11837463
Copy link
Contributor

@gguo11837463 gguo11837463 commented May 8, 2023

BaseTools/Plugin: Too many execute files cause "cmd too long" failure

Windows command prompt have 8191 characters limitation,
enhance it to make command too long can be resloved.

Provide an example, if have too many cov files, it causes to run single
command over the 8191 characters limitation.

OpenCppCoverage
--export_type binary:coverage.cov
--working_dir={workspace}Build
--input_coverage=AAA.cov
...
--input_coverage=NNN.cov

The solution is passing many coverage files in single command line to
breaking it up into many command lines with one coverage file per
command line in order to prevent single line is over to 8191 characters.

  • Command Line 1

OpenCppCoverage
--export_type binary:coverage.cov
--working_dir={workspace}Build
--input_coverage=AAA.cov
--input_coverage=coverage.cov
...

  • Command Line N

OpenCppCoverage
--export_type. binary:coverage.cov
--working_dir={workspace}Build
--input_coverage=NNN.cov
--input_coverage=coverage.cov

Cc: Michael D Kinney michael.d.kinney@intel.com
Cc: Sean Brogan sean.brogan@microsoft.com
Cc: Michael Kubacki mikuback@linux.microsoft.com
Cc: Rebecca Cran rebecca@bsdio.com
Cc: Liming Gao gaoliming@byosoft.com.cn
Cc: Bob Feng bob.c.feng@intel.com
Cc: Yuwei Chen yuwei.chen@intel.com
Signed-off-by: Gua Guo gua.guo@intel.com
Reviewed-by: Michael Kubacki mikuback@linux.microsoft.com
Reviewed-by: Michael D Kinney michael.d.kinney@intel.com

@gguo11837463 gguo11837463 force-pushed the code_coverage_enhance branch 16 times, most recently from 27a0d2c to 61e1023 Compare May 11, 2023 02:11
Windows command prompt have 8191 characters limitation,
enhance it to make command too long can be resloved.

Provide an example, if have too many cov files, it causes to run single
command over the 8191 characters limitation.
> OpenCppCoverage
>  --export_type binary:coverage.cov
>  --working_dir={workspace}Build
>  --input_coverage=AAA.cov
>  ...
>  --input_coverage=NNN.cov

The solution is passing many coverage files in single command line to
breaking it up into many command lines with one coverage file per
command line in order to prevent single line is over to 8191 characters.

- Command Line 1
> OpenCppCoverage
>  --export_type binary:coverage.cov
>  --working_dir={workspace}Build
>  --input_coverage=AAA.cov
>  --input_coverage=coverage.cov
...

- Command Line N
> OpenCppCoverage
>  --export_type. binary:coverage.cov
>  --working_dir={workspace}Build
>  --input_coverage=NNN.cov
>  --input_coverage=coverage.cov

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Gua Guo <gua.guo@intel.com>
Reviewed-by: Michael Kubacki <mikuback@linux.microsoft.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
@lgao4 lgao4 added the push Auto push patch series in PR if all checks pass label May 11, 2023
@mergify mergify bot merged commit 6dd6416 into tianocore:master May 11, 2023
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants