MdeModulePkg/SmbiosDxe: Fix BcdRevision is not match with SMBIOS version #4771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liencx
force-pushed
the
master_fix_smbios_bcdrevision
branch
3 times, most recently
from
3d8900d
to
cfacc10
Compare
liencx
force-pushed
the
master_fix_smbios_bcdrevision
branch
4 times, most recently
from
527f7ef
to
04287cd
Compare
liencx
commented
Sep 14, 2023
Comment on lines
+1075
to
+1078
| EntryPointStructureData.SmbiosBcdRevision = 0; | ||
| if ((mPrivateData.Smbios.MajorVersion <= 9) && (mPrivateData.Smbios.MinorVersion <= 9)) { | ||
| EntryPointStructureData.SmbiosBcdRevision = ((mPrivateData.Smbios.MajorVersion & 0x0f) << 4) | (mPrivateData.Smbios.MinorVersion & 0x0f); | ||
| } |
There was a problem hiding this comment.
It is major code changes.
liencx
force-pushed
the
master_fix_smbios_bcdrevision
branch
4 times, most recently
from
8185302
to
d2745fc
Compare
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4544 These value of Major/Minor version are updated from SMBIOS memory data, but BCD Revision is updated from PCD PcdSmbiosVersion. We should also update BCD Revision from SMBIOS memory data, to ensure that get consistent version value. Cc: Zhiguang Liu <zhiguang.liu@intel.com> Reviewed-by: Gua Guo <gua.guo@intel.com> Reviewed-by: Dandan Bi <dandan.bi@intel.com> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com> Cc: Star Zeng <star.zeng@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Signed-off-by: HoraceX Lien <horacex.lien@intel.com>
liencx
force-pushed
the
master_fix_smbios_bcdrevision
branch
from
d2745fc
to
ae9bc62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4544
These value of Major/Minor version are updated from SMBIOS memory data, but BCD Revision is updated from PCD PcdSmbiosVersion. We should also update BCD Revision from SMBIOS memory data, to ensure that get consistent version value.
Cc: Zhiguang Liu zhiguang.liu@intel.com
Reviewed-by: Gua Guo gua.guo@intel.com
Reviewed-by: Dandan Bi dandan.bi@intel.com
Reviewed-by: Michael D Kinney michael.d.kinney@intel.com
Cc: Star Zeng star.zeng@intel.com
Cc: Zhichao Gao zhichao.gao@intel.com
Signed-off-by: HoraceX Lien horacex.lien@intel.com