Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncrustify GoogleTest update #4957

Merged
merged 8 commits into from
Oct 27, 2023
Merged

Uncrustify GoogleTest update #4957

merged 8 commits into from
Oct 27, 2023

Conversation

mdkinney
Copy link
Member

v1 -> v2:

  • Update commit message to explain the audit only mode change is
    temporary to prevent intermediate CI failures.
  • Format patch Cc's correctly

v1 archive:https://edk2.groups.io/g/devel/message/107665

Cc: Sean Brogan sean.brogan@microsoft.com
Cc: Michael Kubacki mikuback@linux.microsoft.com
Cc: Michael D Kinney michael.d.kinney@intel.com
Cc: Liming Gao gaoliming@byosoft.com.cn
Cc: Jiewen Yao jiewen.yao@intel.com
Cc: Jian J Wang jian.j.wang@intel.com
Cc: Zhiguang Liu zhiguang.liu@intel.com
Cc: Hao A Wu hao.a.wu@intel.com
Cc: Ray Ni ray.ni@intel.com
Signed-off-by: Vivian Nowka-Keane vnowkakeane@linux.microsoft.com

@VivianNK @mdkinney
.pytool: Set uncrustify check to audit only (temporary)
cf3f576 
Temporarily set uncrustify to audit only mode so the following commits can adjust the code for new formatting settings before those settings are applied.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
@VivianNK @mdkinney
.pytool: Add cpp support to uncrustify plugin
2be4b2e 
Modified the uncrustify config to apply cpp specific formatting rules.
Modified uncrustify check to include *.cpp files.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
@VivianNK @mdkinney
MdeModulePkg: Apply uncrustify formatting to relevant files.
791bdfc 
Apply uncrustify formatting to GoogleTest cpp files and respective
header file.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
@VivianNK @mdkinney
MdePkg: Apply uncrustify formatting to relevant files
376a730 
Apply uncrustify formatting to GoogleTest cpp and header files.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
@VivianNK @mdkinney
SecurityPkg: Apply uncrustify formatting to relevant files
22fc21b 
Apply uncrustify formatting to GoogleTest cpp and header files.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
@VivianNK @mdkinney
UnitTestFrameworkPkg: Apply uncrustify formatting to relevant files
75cc0fc 
Apply uncrustify formatting to GoogleTest cpp and header files.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>
@VivianNK @mdkinney
.pytool: Undo uncrustify check change
2d85e99 
Set global audit only to False now that new rules have been applied to
all necessary packages.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
@mdkinney mdkinney added the push Auto push patch series in PR if all checks pass label Oct 27, 2023
@mergify mergify bot merged commit ca32f75 into tianocore:master Oct 27, 2023
123 checks passed
@VivianNK VivianNK mentioned this pull request Dec 21, 2023
Merged
5 tasks
VivianNK added a commit to microsoft/mu_feature_config that referenced this pull request Dec 21, 2023
@VivianNK
SetupDataPkg: apply cpp uncrustify changes (#291)
02367f1 
## Description

Updating Mu projects to apply uncrusty formatting for Cpp files, config
updated upstream in edk2 tianocore/edk2#4957 .

Config will be updated in mu_basecore
microsoft/mu_basecore#609.

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

Local CI build

## Integration Instructions

N/A
This was referenced Dec 21, 2023
Merged
Merged
VivianNK added a commit to microsoft/mu_feature_ipmi that referenced this pull request Dec 22, 2023
@VivianNK
IpmiFeaturePkgPkg: apply cpp uncrustify changes (#197)
6eac048 
## Description

Updating Mu projects to apply uncrusty formatting for Cpp files, config
updated upstream in edk2 tianocore/edk2#4957 .

Config will be updated in mu_basecore
microsoft/mu_basecore#609.

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

Local CI build

## Integration Instructions

N/A
VivianNK added a commit to microsoft/mu_tiano_plus that referenced this pull request Dec 22, 2023
@VivianNK
[CHERRY-PICK] SecurityPkg: Apply uncrustify formatting to relevant fi…
48e292c 
…les (#215)

## Description

Updating Mu projects to apply uncrusty formatting for Cpp and header
files, config updated upstream in edk2
tianocore/edk2#4957 .

Config will be updated in mu_basecore
microsoft/mu_basecore#609.

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Breaks Uncrustify check on header file. Dependent on Uncrustify update
in mu_basecore (microsoft/mu_basecore#609)
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

Local CI build using a local mu_basecore branch with the Uncrustify
config changes.

## Integration Instructions

Project needs update mu_basecore with config changes.

Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
kenlautner pushed a commit to microsoft/mu_tiano_plus that referenced this pull request Jan 19, 2024
@VivianNK @kenlautner
[CHERRY-PICK] SecurityPkg: Apply uncrustify formatting to relevant fi…
eee3c3e 
…les (#215)

Updating Mu projects to apply uncrusty formatting for Cpp and header
files, config updated upstream in edk2
tianocore/edk2#4957 .

Config will be updated in mu_basecore
microsoft/mu_basecore#609.

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Breaks Uncrustify check on header file. Dependent on Uncrustify update
in mu_basecore (microsoft/mu_basecore#609)
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

Local CI build using a local mu_basecore branch with the Uncrustify
config changes.

Project needs update mu_basecore with config changes.

Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdkinney @VivianNK