Skip to content
This repository has been archived by the owner on Oct 18, 2022. It is now read-only.

changelogs of "native" packages are missing #216

Closed
henning-schild opened this issue Sep 4, 2021 · 3 comments
Closed

changelogs of "native" packages are missing #216

henning-schild opened this issue Sep 4, 2021 · 3 comments

Comments

@henning-schild
Copy link

/etc/dpkg/dpkg.cfg.d/excludes is only allowing /usr/share/doc/*/changelog.Debian.* but not /usr/share/doc/*/changelog.*

The result is that even the Debian changelog will be missing for "native" packages.

http://manpages.ubuntu.com/manpages/impish/en/man1/dh_installchangelogs.1.html

      The changelog file is installed with a name of changelog for native packages, and
      changelog.Debian for non-native packages.  The NEWS file is always installed with a
      name of NEWS.Debian.

I think the excludes file should instead use /usr/share/doc/*/changelog.* to include Debian changelogs no matter what kind of package "native" vs. "non-native". Doing that would also not exclude upstream changelogs, which might grow that image but probably be just as valid as keeping the Debian changelog.

I hope this is the right place, did not find the code responsible and that exclude is already in the images coming from https://partner-images.canonical.com/core/

henning-schild added a commit to henning-schild-work/isar that referenced this issue Sep 4, 2021
we fork away from ubuntu where the excludes files came from

tianon/docker-brew-ubuntu-core#216
henning-schild added a commit to henning-schild-work/isar that referenced this issue Sep 6, 2021
So called "native" packages will put the debian changelog into the
package as "changelog" and not "changelog.Debian".
dh_installchangelogs(1)

We have the file from ubuntu and with this change we start doing things
differently. For isar "raw" packages will be "native" so we probably
want that no matter what ubuntu might think. I still started a
discussion on the topic.
tianon/docker-brew-ubuntu-core#216

This was found when working on reproducible builds, for some reason the
changelogs of the raw packages did not differ, because they are not in
the rootfs.

Reported-by: <Venkata.Pyla@toshiba-tsip.com>
Signed-off-by: Henning Schild <henning.schild@siemens.com>
amikan pushed a commit to ilbers/isar that referenced this issue Sep 7, 2021
So called "native" packages will put the debian changelog into the
package as "changelog" and not "changelog.Debian".
dh_installchangelogs(1)

We have the file from ubuntu and with this change we start doing things
differently. For isar "raw" packages will be "native" so we probably
want that no matter what ubuntu might think. I still started a
discussion on the topic.
tianon/docker-brew-ubuntu-core#216

This was found when working on reproducible builds, for some reason the
changelogs of the raw packages did not differ, because they are not in
the rootfs.

Reported-by: <Venkata.Pyla@toshiba-tsip.com>
Signed-off-by: Henning Schild <henning.schild@siemens.com>
@tianon
Copy link
Owner

tianon commented Sep 8, 2021

I think your chances of reaching the folks who maintain the tarballs are higher if you file an issue on https://bugs.launchpad.net/cloud-images (including the docker tag).

@henning-schild
Copy link
Author

@tianon
Copy link
Owner

tianon commented Sep 9, 2021

Perfect, closing in favor of that 👍

@tianon tianon closed this as completed Sep 9, 2021
amikan pushed a commit to ilbers/isar that referenced this issue Dec 15, 2021
So called "native" packages will put the debian changelog into the
package as "changelog" and not "changelog.Debian".
dh_installchangelogs(1)

We have the file from ubuntu and with this change we start doing things
differently. For isar "raw" packages will be "native" so we probably
want that no matter what ubuntu might think. I still started a
discussion on the topic.
tianon/docker-brew-ubuntu-core#216

This was found when working on reproducible builds, for some reason the
changelogs of the raw packages did not differ, because they are not in
the rootfs.

Reported-by: <Venkata.Pyla@toshiba-tsip.com>
Signed-off-by: Henning Schild <henning.schild@siemens.com>
amikan pushed a commit to ilbers/isar that referenced this issue Dec 17, 2021
So called "native" packages will put the debian changelog into the
package as "changelog" and not "changelog.Debian".
dh_installchangelogs(1)

We have the file from ubuntu and with this change we start doing things
differently. For isar "raw" packages will be "native" so we probably
want that no matter what ubuntu might think. I still started a
discussion on the topic.
tianon/docker-brew-ubuntu-core#216

This was found when working on reproducible builds, for some reason the
changelogs of the raw packages did not differ, because they are not in
the rootfs.

Reported-by: <Venkata.Pyla@toshiba-tsip.com>
Signed-off-by: Henning Schild <henning.schild@siemens.com>
amikan pushed a commit to ilbers/isar that referenced this issue Dec 21, 2021
So called "native" packages will put the debian changelog into the
package as "changelog" and not "changelog.Debian".
dh_installchangelogs(1)

We have the file from ubuntu and with this change we start doing things
differently. For isar "raw" packages will be "native" so we probably
want that no matter what ubuntu might think. I still started a
discussion on the topic.
tianon/docker-brew-ubuntu-core#216

This was found when working on reproducible builds, for some reason the
changelogs of the raw packages did not differ, because they are not in
the rootfs.

Reported-by: <Venkata.Pyla@toshiba-tsip.com>
Signed-off-by: Henning Schild <henning.schild@siemens.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants