Add support for .NET 8 #4
Conversation
There was a problem hiding this comment.
Good opportunity to start using renovate? The config you need is here. We also need to opt into renovatebot which I can help with if you choose to do this.
| ENV NEW_RELIC_APPLICATION_LOGGING_FORWARDING_ENABLED false | ||
| ENV NEW_RELIC_DISTRIBUTED_TRACING_ENABLED true | ||
|
|
||
| # This variable enables New Relic (disabled by default) |
There was a problem hiding this comment.
I don't understand the comment here.
There was a problem hiding this comment.
If CORECLR_ENABLE_PROFILING is set to 0 then new relic does not work.
There was a problem hiding this comment.
I see but that comment doesn't really say that. I would have said:
# New Relic requires coreclr profiling to work (disabled by default)
| ENV NEW_RELIC_APPLICATION_LOGGING_FORWARDING_ENABLED false | ||
| ENV NEW_RELIC_DISTRIBUTED_TRACING_ENABLED true | ||
|
|
||
| # This variable enables New Relic (disabled by default) |
There was a problem hiding this comment.
I don't understand the comment here.
There was a problem hiding this comment.
If CORECLR_ENABLE_PROFILING is set to 0 then new relic does not work.
Do you mean in this repo or in the repo using this image? |
|
@ronanbarrett you could add a PR to replace this? https://github.com/tibber/Tibber.ExampleServiceDotnet/blob/main/.github/.dependabot.yml |
|
@toini This is the repo that actually references the base images so this is the really important one to have renovate on I guess? |
|
@ronanbarrett yeah if we will pin the sha in this repo. Then you can add a PR here, too? |
No description provided.