Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made blank equal true #20

Merged
merged 1 commit into from
Sep 12, 2015
Merged

Made blank equal true #20

merged 1 commit into from
Sep 12, 2015

Conversation

pillsbury7901
Copy link
Contributor

Changes made in response to bug report: Allow comment and description fields to remain empty #18

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.8% when pulling 690733d on pillsbury7901:master into a00d470 on tibonihoo:master.

@tibonihoo
Copy link
Owner

Thanks for this contribution. I'm just a little surprised that there is no migration file added to wom_user/migrations. These are generated by django-south when you tell is that the db scheme has changed and they are very important to update the dbs of existing wateronmars installations.

Did you have a chance to use south ?

@pillsbury7901
Copy link
Contributor Author

I believe that I did everything as instructed...It is possible that I could have made a mistake as I am not very familiar with using south. What can I do to correct the problem?

@tibonihoo
Copy link
Owner

Just a heads up (from me), I've had no internet at home for one month, I'll try to find some time to look into this database migration problem (that may not be a problem) in the upcoming weeks.

tibonihoo added a commit that referenced this pull request Sep 12, 2015
@tibonihoo tibonihoo merged commit 17bdbcd into tibonihoo:master Sep 12, 2015
@tibonihoo
Copy link
Owner

Thanks again for your contribution and I'm i for a double dose of excuses, first for the shameful time it took me to get back to this matter, and also because there was indeed no need to migrate, which I could have known if I had read django's doc (Model field reference) correctly:

Note that this is different than null. null is purely database-related, whereas blank is validation-related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants