Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvements #3

Merged
merged 4 commits into from
Oct 10, 2019
Merged

Fixes and improvements #3

merged 4 commits into from
Oct 10, 2019

Conversation

rimiti
Copy link
Collaborator

@rimiti rimiti commented Oct 10, 2019

Purpose

  • When an object is passed to gpuid(), it returns an object.
  • When an array is passed to gpuid(), it returns an array.
  • Stopword package downgraded to 0.1.13
  • Others packages updated

Note

This PR generate some breaking changes, a new major version will be released.

@rimiti rimiti added bug Something isn't working enhancement New feature or request labels Oct 10, 2019
@rimiti rimiti added this to the v3.0.0 milestone Oct 10, 2019
@rimiti rimiti requested a review from Simobain October 10, 2019 09:52
@rimiti rimiti self-assigned this Oct 10, 2019
@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #3   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          61     64    +3     
  Branches        9     10    +1     
=====================================
+ Hits           61     64    +3
Impacted Files Coverage Δ
src/generator.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 339f564...f902dbd. Read the comment docs.

@rimiti rimiti merged commit fee6e11 into master Oct 10, 2019
@rimiti rimiti deleted the fixes branch October 10, 2019 10:07
@rimiti rimiti modified the milestones: v3.0.0, v2.0.0 Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants