Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mini-notation for euclidInv #915

Closed
geikha opened this issue May 27, 2022 · 2 comments · Fixed by #916
Closed

Mini-notation for euclidInv #915

geikha opened this issue May 27, 2022 · 2 comments · Fixed by #916

Comments

@geikha
Copy link
Contributor

geikha commented May 27, 2022

What if inserting negative values into the first argument of euclid mininotation resulted in the inverted version of that euclidian rhythm. So that, for example:

"bd(-3,8)"

was the same as

euclidInv 3 8 $ s "bd"
@ndr-brt
Copy link
Contributor

ndr-brt commented May 28, 2022

Why don't have this implemented directly in the euclid function?
e.g.

euclid (-3) 8

would be the same as

euclidInv 3 8

@geikha
Copy link
Contributor Author

geikha commented May 28, 2022

i didn't even think about it,,, makes more sense tbh

polymorphicengine added a commit to polymorphicengine/Tidal that referenced this issue May 28, 2022
@polymorphicengine
if first argument of euclid is negative, apply euclidInv.
a393b78 
this is also patternable.
+ tests
fixes tidalcycles#915
@polymorphicengine polymorphicengine mentioned this issue May 28, 2022
Merged
@yaxu yaxu closed this as completed in #916 May 29, 2022
@geikha geikha mentioned this issue Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

if first argument of euclid is negative, apply euclidInv polymorphicengine/Tidal
2 participants
@ndr-brt @geikha