Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative numbers not working for boolean euclids #1063

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

geikha
Copy link
Contributor

@geikha geikha commented Jan 19, 2024

As you may remember, with #915 and #916, we added the possibility of using negative values for the first argument of euclidian rhythms. However we forgot to replicate this behaviour for boolean euclidian patterns.

This fixes the following bug I've encountered:

-- works
d1 $ mask "t(5,16)" $ s "808lt*16" |- note (saw*2) # shape 0.3 # octave 6

-- goes silent:
d1 $ mask "t(-5,16)" $ s "808lt*16" |- note (saw*2) # shape 0.3 # octave 6

fixes stuff like `mask "t(-5,16)"` not work
@mindofmatthew mindofmatthew merged commit d130059 into tidalcycles:1.10-dev Mar 30, 2024
@mindofmatthew
Copy link
Contributor

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants