Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini notation: add underscore elongation #47

Closed
wants to merge 6 commits into from
Closed

Mini notation: add underscore elongation #47

wants to merge 6 commits into from

Conversation

eilseq
Copy link

@eilseq eilseq commented Apr 12, 2022

This pull request add the underscore elongation mini notation to the related package. Expected behaviour monitored by tests is:

assert.deepStrictEqual(minS('a@2 b@3'), ['a: 0 - 2/5', 'b: 2/5 - 1']);  // @ elongation
assert.deepStrictEqual(minS('a _ b _ _'), ['a: 0 - 2/5', 'b: 2/5 - 1']);   // _ elongation

@eilseq eilseq mentioned this pull request Apr 12, 2022
14 tasks
@@ -26,6 +27,7 @@
"homepage": "https://github.com/tidalcycles/strudel#readme",
"dependencies": {
"@strudel.cycles/eval": "^0.0.3",
"@strudel.cycles/tone": "^0.0.4"
"@strudel.cycles/tone": "^0.0.4",
"peggy": "^1.2.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you move this to devDependencies? no need to install it when using it in the browser

@eilseq eilseq closed this by deleting the head repository Sep 9, 2022
yaxu added a commit that referenced this pull request Jan 19, 2024
- `.` feet now work, e.g. `"a b c . d e . f"` is the same as `"[a b c] [d e] [f]"`
- `_` elongation now works, e.g. `"a _ _ b"` is the same as `"a@3 b"` (`"a @ @ b"` also works, like in tidal)
- standalone `!` now works, e.g. `"a ! ! b"` is the same as `"a!3 b"`

Reworks #47 and #49
Ref #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants