Mini notation: add dot sub-cycles #49

eilseq · 2022-04-12T10:35:26Z

This pull request add the dot sub-cycles mini notation to the related package. Equivalent to existing [ ] behaviour. Expected behaviour monitored by tests is:

assert.deepStrictEqual(minS('c3 [d3 e3]'), ['c3: 0 - 1/2', 'd3: 1/2 - 3/4', 'e3: 3/4 - 1']);
assert.deepStrictEqual(minS('c3 [d3 [e3 f3]]'), ['c3: 0 - 1/2', 'd3: 1/2 - 3/4', 'e3: 3/4 - 7/8', 'f3: 7/8 - 1']);
assert.deepStrictEqual(minS('c3 . d3 e3'), ['c3: 0 - 1/2', 'd3: 1/2 - 3/4', 'e3: 3/4 - 1']);
assert.deepStrictEqual(minS('c3 d3 [e3 f3]'), ['c3: 0 - 1/3', 'd3: 1/3 - 2/3', 'e3: 2/3 - 5/6', 'f3: 5/6 - 1']);
assert.deepStrictEqual(minS('c3 . d3 . e3 f3'), ['c3: 0 - 1/3', 'd3: 1/3 - 2/3', 'e3: 2/3 - 5/6', 'f3: 5/6 - 1']);

felixroos · 2022-04-13T17:25:53Z

packages/mini/test/mini.test.mjs

    assert.deepStrictEqual(minS('c3 [d3 [e3 f3]]'), ['c3: 0 - 1/2', 'd3: 1/2 - 3/4', 'e3: 3/4 - 7/8', 'f3: 7/8 - 1']);
+    assert.deepStrictEqual(minS('c3 . d3 . e3 f3'), ['c3: 0 - 1/2', 'd3: 1/2 - 3/4', 'e3: 3/4 - 7/8', 'f3: 7/8 - 1']);


unfortunately, this is not how it works in tidal.. it should have the same result as [c3] [d3] [e3 f3]

- `.` feet now work, e.g. `"a b c . d e . f"` is the same as `"[a b c] [d e] [f]"` - `_` elongation now works, e.g. `"a _ _ b"` is the same as `"a@3 b"` (`"a @ @ b"` also works, like in tidal) - standalone `!` now works, e.g. `"a ! ! b"` is the same as `"a!3 b"` Reworks #47 and #49 Ref #30

eilseq mentioned this pull request Apr 12, 2022

add missing mini notation features #30

Open

14 tasks

felixroos reviewed Apr 13, 2022

View reviewed changes

eilseq added 8 commits September 9, 2022 13:55

update package-lock files (auto-generated)

12ebe89

add slice modifier - underscore elongation

5801724

update test

d653251

install peggy and update scripts

08179a8

update test

038df0d

add dot sub cycle to grammar and compile parser

0bf70c4

update test

ec69aa0

update mini test

23c55d8

eilseq closed this by deleting the head repository Sep 9, 2022

yaxu mentioned this pull request Jan 19, 2024

Mini-notation additions towards tidal compatibility #926

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mini notation: add dot sub-cycles #49

Mini notation: add dot sub-cycles #49

eilseq commented Apr 12, 2022 •

edited

felixroos Apr 13, 2022

		assert.deepStrictEqual(minS('c3 [d3 [e3 f3]]'), ['c3: 0 - 1/2', 'd3: 1/2 - 3/4', 'e3: 3/4 - 7/8', 'f3: 7/8 - 1']);
		assert.deepStrictEqual(minS('c3 . d3 . e3 f3'), ['c3: 0 - 1/2', 'd3: 1/2 - 3/4', 'e3: 3/4 - 7/8', 'f3: 7/8 - 1']);

Mini notation: add dot sub-cycles #49

Mini notation: add dot sub-cycles #49

Conversation

eilseq commented Apr 12, 2022 • edited

felixroos Apr 13, 2022

Choose a reason for hiding this comment

eilseq commented Apr 12, 2022 •

edited