Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZZFX Synth support #684

Merged
merged 18 commits into from Aug 31, 2023
Merged

ZZFX Synth support #684

merged 18 commits into from Aug 31, 2023

Conversation

Bubobubobubobubo
Copy link
Contributor

This draft PR implements some boilerplate for ZZFX support.

@Bubobubobubobubo Bubobubobubobubo changed the title Boilerplate for ZZFX Synth support ZZFX Synth support Aug 30, 2023
@felixroos felixroos marked this pull request as ready for review August 31, 2023 04:23
@felixroos
Copy link
Collaborator

felixroos commented Aug 31, 2023

this looks almost ready..

I've tried to reuse as many params as possible. reused are:

  • s
  • note = 36
  • freq
  • attack = 0
  • decay = 0
  • sustain = 0.8
  • release = 0.1

New are:

  • slide = 0 (already a control in superdirt)
  • zrand = 0
  • curve = 1
  • deltaSlide = 0
  • pitchJump = 0
  • pitchJumpTime = 0
  • lfo = 0 (or repeatTime)
  • noise = 0
  • zmod = 0
  • zcrush = 0 (like bitcrush but scaled differently)
  • zdelay = 0 (a more simple form of delay)
  • tremolo = 0

maybe find shorter names for deltaSlide, pitchJump, pitchJumpTime and repeatTime? or alternatively add aliases later

@Bubobubobubobubo
Copy link
Contributor Author

I'm not sure if more aliases are a good thing for the moment. It will become quite hard to decipher what these do and their behavior is quite specific. I would say that it is ready enough as it is.

@felixroos felixroos merged commit e4ea786 into tidalcycles:main Aug 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants