-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vanilla repl #779
Closed
Closed
vanilla repl #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add reevaluate and panic shortcuts
- might still be buggy! - smarter way to flush sounds
+ react is now only used for ui around editor! + ui still not fully functional
+ use new prebake
- keybindings - line numbers - line wrapping - highlighting (new) - flashing (new) - autocomplete not working yet - move themes to codemirror package (currently duplicated) - generally simplify settings handling
+ fix hidden line number style
Merged
repackaged this partly in #863 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
approaches #776
hopeful outcomes:
this is a bigger refactoring, with the goal of getting rid of @strudel.cycles/react + its dependency on
@uiw/react-codemirror
.Currently, the main pieces of the react package are
useStrudel
(used in main repl) +MiniRepl
(used in docs).It also holds all of the codemirror themes.
I came to realize that react is not very practical to implement these things, as they are mostly data structures + state management without much ui. It was never a well thought out decision, as the use of react for these non-ui things just grew out of the ui written with react (which is still a good choice imo).
Instead, the plan is to implement the main repl + the mini repl with the @strudel/codemirror package, which is a much thinner wrapper around the core repl (repl.mjs). It is just vanilla js, using codemirror directly instead of going through another wrapper package (
@uiw/react-codemirror
).What I've done so far:
todo:
panic
will silence fx sends, then add reevaluate + panic stop