Vanilla repl 2 #863
Merged
Vanilla repl 2 #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add themes from react package - add Autocomplete from react package - handle dynamic extensions - handle keyboard shortcuts - make StrudelMirror as capable as Repl
+ disable autocomplete for now
|
I've now added back the /vanilla route where the new vanilla implementation can be tested without interfering with the / route. I'd say this is ready to merge, the many lines are mostly the duplicated themes, the lockfile and the new examples (strudelmirror + /vanilla route). When this turns out fine, the next PR can replace the / route with the new logic + remove a LOT of code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
second take on #779
this time keeping the existing repl as is and only duplicating logic to the codemirror package.
It should make sense to test this thoroughtly before replacing anything of the existing repl.
the good news: the editor (codemirror) with all its features now runs completely on vanilla js.