Reorder sampling docs #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This build check is failing, does it depend on your previous PR (#269)? |
seems like I had to update |
|
Hi @cleary! Is this PR going to be merged or should I close it? |
|
Just leave it open for the moment - I was attempting to gain some clarity on the status of a bigger rewrite and how we handle changes happening in the meantime. I need to review when I have a bit of spare time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restructures the samplers and sampling pages of the documentation so that groupings make more sense, follow up to PR #269.
SAMPLERS PAGE
ampandgainwere moved from samplers>basic sample manipulation to audio effects.accelerate,speed,unit,timescale, andtimescalewin). I thus renamed samplers to sample_speedSAMPLING PAGE
segment,discretise,sig) to oscillators.loopAtto the previously renamed sample_speed pageThis PR also updates
sidebars.js, which should make the new page of the previous PR appear.