Fix nationalrail app #1225
Merged
Fix nationalrail app #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Responding to bug pointed out by users here, sorry it's taken a while: https://discuss.tidbyt.com/t/national-rail/4485/2 The thread was helpful for pointing out that the issue occurs only when setting a filter. I found I got an error whenever a filter station was selected. That's because I was putting a whole JSON object into the filter condition, rather than just the relevant CRS value. Tested this locally and no longer get an error when setting a filter.
dinosaursrarr
requested review from
betterengineering and
matslina
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responding to bug pointed out by users here, sorry it's taken a while: https://discuss.tidbyt.com/t/national-rail/4485/2
The thread was helpful for pointing out that the issue occurs only when setting a filter. I found I got an error whenever a filter station was selected.
That's because I was putting a whole JSON object into the filter condition, rather than just the relevant CRS value. Tested this locally and no longer get an error when setting a filter.