Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix node.js 20+ compatibility with commander.js #230

Closed
wants to merge 1 commit into from

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented Jul 29, 2024

Adds support for Node.js 20+ and this error:

TypeError: Cannot read properties of undefined (reading 'commands')
    at Module.config (/Users/user/.nvm/versions/node/v18.19.0/lib/node_modules/liveview/dist/node/commands/serve.js:28:46)
    at CLI.loadCommand (file:///Users/v/.nvm/versions/node/v20.11.0/lib/node_modules/titanium/src/cli.js:927:32)
    at async file:///Users/user/.nvm/versions/node/v20.11.0/lib/node_modules/titanium/src/cli.js:810:4
    at async Command.parseAsync (/Users/user/.nvm/versions/node/v20.11.0/lib/node_modules/titanium/node_modules/commander/lib/command.js:1092:5)
    at async CLI.go (file:///Users/user/.nvm/versions/node/v20.11.0/lib/node_modules/titanium/src/cli.js:532:3)
    at async file:///Users/user/.nvm/versions/node/v20.11.0/lib/node_modules/titanium/src/main.js:8:2

@janvennemann janvennemann changed the base branch from master to next/vite-4 July 30, 2024 12:21
@janvennemann
Copy link
Contributor

Closing since this issue is related to the next branch of Liveview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants