Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): cookies updated while reloading webview #11415

Merged
merged 4 commits into from
Jan 9, 2020
Merged

fix(ios): cookies updated while reloading webview #11415

merged 4 commits into from
Jan 9, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 9.0.0 milestone Jan 8, 2020
@build build requested a review from a team January 8, 2020 00:29
@build
Copy link
Contributor

build commented Jan 8, 2020 •
edited
Loading

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6550 tests are passing.
(There are 700 skipped tests not included in that total)

Generated by 🚫 dangerJS against 863683e

@sgtcoolguy
Copy link
Contributor

I think this needs an 8_3_X backport...

janvennemann
janvennemann approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssekhri
Copy link

ssekhri commented Jan 9, 2020

FR Passed. The cookies are updated while reloading the webview.
Verified on:
Verified on:
Mac OS: 10.15.1
SDK: 9.0.0.v20200108141913
Appc CLI: 7.1.2
JDK: 11.0.4
Node: 10.16.3
Studio: 6.0.0.201911251516
Xcode: 11.2
Device: iOS simulator 13.2

@ssekhri ssekhri merged commit fc11337 into tidev:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@vijaysingh-axway @build @sgtcoolguy @ssekhri @janvennemann