Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)(8_3_X): getCurrentPosition() compatibility with some Samsung devices #11426

Merged
merged 6 commits into from
Jan 15, 2020
Merged

fix(android)(8_3_X): getCurrentPosition() compatibility with some Samsung devices #11426

merged 6 commits into from
Jan 15, 2020

Conversation

garymathews
Copy link
Contributor

@sgtcoolguy sgtcoolguy added this to the 8.3.1 milestone Jan 9, 2020
@build build requested a review from a team January 9, 2020 16:41
@build
Copy link
Contributor

build commented Jan 9, 2020 •
edited
Loading

Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6628 tests are passing.
(There are 710 skipped tests not included in that total)

Generated by 🚫 dangerJS against d773db5

@sgtcoolguy
Copy link
Contributor

ping @lokeshchdhry looks like this is a backport/cherry-pick of a PR you original did the FR on...

sgtcoolguy
sgtcoolguy approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given it's a cherry-pick/backport of an approved PR on master, I'm going to rubber-stamp this one..

@lokeshchdhry
Copy link
Contributor

FR Passed.

Location data is obtained successfully after toggling location on Samsung devices.

Studio Ver: 6.0.0.201911251516
SDK Ver: 8.3.1 local build
OS Ver: 10.14.5
Xcode Ver: Xcode 11.2.1
Appc NPM: 5.0.0-2
Appc CLI: 7.1.2
Daemon Ver: 1.1.3
Ti CLI Ver: 5.2.2
Alloy Ver: 1.14.4
Node Ver: 12.13.1
NPM Ver: 6.12.1
Java Ver: 11.0.1
Android Devices: ⇨ samsung SM-G955U1 (Android 9), Pixel Android 10.

@lokeshchdhry lokeshchdhry merged commit 1e832a6 into tidev:8_3_X Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees

@lokeshchdhry lokeshchdhry

Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
8.3.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @build @sgtcoolguy @lokeshchdhry