feat(ios): use/support/build xcframeworks #12026

sgtcoolguy · 2020-09-09T18:40:38Z

JIRA: https://jira.appcelerator.org/browse/TIMOB-28116

Description:
This is required for #11955

These are the changes to move to using xcframeworks for APS, tiverify, TitaniumKit and for native modules.

This includes changes to the libraries:

appcelerator/aps_sdk#347
XCFramework / Mac support APSHTTPClient#54
appcelerator/titanium_verify#33

Xcode minimum is bumped to 11 as that is required for xcframework support.

This PR does build/include the built maccatalyst binaries in the xcframeworks. It does not enable macOS as a target platform. #11955 will be used for that.

Note that to avoid breaking existing native modules we will selectively exclude arm64 from simulator builds of apps if we detect a native module that is not an xcframework - or is built with Xcode 11 and is missing arm64 simulator binaries.

If the developer is running an arm64 Mac build of Node (there are none yet officially!), and a native module is assumed to not have arm64 sim support, we'll error out with a message about it. (the "fix" there is for us/them to rebuild the native modules using Xcode 12 w/ xcframework support)

TODO

Address @vijaysingh-axway review feedback around use of Info.plist from xcframework to determine arch/folder name support.
make the arm64 sim exclusion smarter by handling if an xcframework has no arm64 sim support.

- https://github.com/appcelerator/aps_sdk/pull/347 - tidev/APSHTTPClient#54 - https://github.com/appcelerator/titanium_verify/pull/33

build · 2020-09-09T18:58:37Z

	Fails
🚫	Tests have failed, see below for more information.

	Warnings
⚠️	iphone/cli/hooks/frameworks.js#L60 - iphone/cli/hooks/frameworks.js line 60 – Avoid calling back inside of a promise. (promise/no-callback-in-promise)
⚠️	iphone/cli/hooks/frameworks.js#L60 - iphone/cli/hooks/frameworks.js line 60 – Expected catch() or return (promise/catch-or-return)
⚠️	iphone/cli/hooks/frameworks.js#L79 - iphone/cli/hooks/frameworks.js line 79 – Avoid wrapping return values in Promise.resolve (promise/no-return-wrap)
⚠️	iphone/cli/hooks/frameworks.js#L429 - iphone/cli/hooks/frameworks.js line 429 – Each then() should return a value or throw (promise/always-return)

	Messages
📖	💾 Here's the generated SDK zipfile.
📖	✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖	❌ 1 tests have failed There are 1 tests failing and 711 skipped out of 8156 total tests.

Tests:

Classname

Name

Time

Error

ios.ipad.Titanium.UI.iOS.CollisionBehavior.example

works (14.0)

15

Error: timeout of 15000ms exceeded
file:///Users/build/Library/Developer/CoreSimulator/Devices/AEB0AAF4-FED7-4BF5-8DDC-233DE4C6A1FF/data/Containers/Bundle/Application/D13CAFE1-684E-411F-8DCE-C42F4582C3BA/mocha.app/ti-mocha.js:4326:27

Generated by 🚫 dangerJS against 692b1c0

sgtcoolguy · 2020-09-09T19:08:12Z

@vijaysingh-axway This is the xcframeworks only changes. I addressed your initial feedback re: Xcode 11 built xcframeworks in a lazy/dumb way - checking for the Xcode 12+ dir name and falling back to the Xcode 11 folder name (rather than try and get fancy with parsing Info.plist).

If we see an xcframework built on Xcode 11 missing arm64, we'll exclude arm64 on app simulator builds just as we would for a non-xcframework based native module.

vijaysingh-axway · 2020-09-09T19:55:16Z

iphone/Classes/ContactsModule.h

@@ -6,7 +6,7 @@
 */
 #import <TitaniumKit/TiModule.h>

-#ifdef USE_TI_CONTACTS
+#if defined(USE_TI_CONTACTS) && (!TARGET_OS_MACCATALYST || IS_SDK_IOS_14)


I see that TARGET_OS_MACCATALYST is getting used. I guess it is not removed intentionally to save time. I think it is fine.

Contacts API is available in Mac Catalyst 14+. So I intentionally guarded here like this.

vijaysingh-axway

@sgtcoolguy Changes looks good. I have left few comments. Basically questions. Can you look in that? Thanks!

iphone/cli/commands/_buildModule.js

iphone/iphone/Titanium.entitlements

iphone/iphone/Titanium.xcodeproj/project.pbxproj

iphone/package.json

ewanharris · 2020-09-10T12:10:28Z

@sgtcoolguy couple notes from me using this.

Warning on buildModule.js line 214 probably needs the FRAMEWORK_SEARCH_PATHS value changing https://github.com/appcelerator/titanium_mobile/blob/5c0c9188a242e809b2091c08c8047e357da026ba/iphone/cli/commands/_buildModule.js#L214-L219
When building a module in a dirty state (i.e. it's been built once) I get the below, before creating the universal binary do we maybe need to remove some files first?

[DEBUG] Running: /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -create-xcframework -library /Users/awam/git/modules/ti.coremotion/ios/build/iphoneos.xcarchive/Products/usr/local/lib/libti.coremotion.a -headers /Users/awam/git/modules/ti.coremotion/ios/build/dummyheader/ -library /Users/awam/git/modules/ti.coremotion/ios/build/iphonesimulator.xcarchive/Products/usr/local/lib/libti.coremotion.a -headers /Users/awam/git/modules/ti.coremotion/ios/build/dummyheader/ -library /Users/awam/git/modules/ti.coremotion/ios/build/macosx.xcarchive/Products/usr/local/lib/libti.coremotion.a -headers /Users/awam/git/modules/ti.coremotion/ios/build/dummyheader/ -output /Users/awam/git/modules/ti.coremotion/ios/build/ti.coremotion.xcframework
[ERROR] Failed to generate universal binary (code 70):
[ERROR] “libti.coremotion.a” couldn’t be copied to “ios-arm64_x86_64-maccatalyst” because an item with the same name already exists.

Fixes TIMOB-28072

…xcframeworks Modules built before xcframework support do not have an arm64 sim arch/target To avoid having to break all modules, we'll try and exclude arm64 from sim builds This will eventually break if app is built on arm64 apple silicon and a new xcframework based module hasn't been shipped.

- preserve symlinks in module xcframeworks/zips

sgtcoolguy · 2020-09-10T14:43:05Z

@ewanharris I've incorporated your feedback. Updated the line for the framework search path sniffing, and right before we create-xcframework we'll wipe the destination if it exists to avoid the "couldn't be copied" error.

build(ios): update APS libraries, tiverify to xcframework

da8656d

- https://github.com/appcelerator/aps_sdk/pull/347 - tidev/APSHTTPClient#54 - https://github.com/appcelerator/titanium_verify/pull/33

sgtcoolguy added ios feature labels Sep 9, 2020

sgtcoolguy requested a review from vijaysingh-axway September 9, 2020 18:40

sgtcoolguy mentioned this pull request Sep 9, 2020

feat(ios): macOS target support #11955

Merged

build added this to the 9.2.0 milestone Sep 9, 2020

build requested a review from a team September 9, 2020 18:58

build added the needs tests 🚨 label Sep 9, 2020

sgtcoolguy added no tests and removed needs tests 🚨 labels Sep 9, 2020

sgtcoolguy force-pushed the xcframeworks branch from 1c5f847 to 970413a Compare September 9, 2020 19:06

vijaysingh-axway reviewed Sep 9, 2020

View reviewed changes

iphone/cli/commands/_buildModule.js Show resolved Hide resolved

iphone/iphone/Titanium.entitlements Outdated Show resolved Hide resolved

iphone/iphone/Titanium.xcodeproj/project.pbxproj Show resolved Hide resolved

iphone/package.json Show resolved Hide resolved

sgtcoolguy added the in-qe-testing 🕵 label Sep 9, 2020

sgtcoolguy added 5 commits September 10, 2020 08:43

refactor(ios): guard APIs for mac catalyst target

40ab20d

chore(ios)!: set minimum xcode to 11.x

6965e81

Fixes TIMOB-28072

feat(ios): use/support/build xcframeworks

0b9caad

feat(ios): build modules as xcframeworks (w/ macos support)

692b1c0

- preserve symlinks in module xcframeworks/zips

sgtcoolguy force-pushed the xcframeworks branch from 970413a to 692b1c0 Compare September 10, 2020 12:44

sgtcoolguy mentioned this pull request Sep 10, 2020

chore(ios)!: set minimum xcode to 11.x #12022

Closed

sgtcoolguy added the backport 9_3_X label Sep 10, 2020

sgtcoolguy merged commit 5b766ae into tidev:master Sep 10, 2020

build mentioned this pull request Sep 10, 2020

[Backport 9_3_X] feat(ios): use/support/build xcframeworks #12033

Merged

build removed the backport 9_3_X label Sep 10, 2020

sgtcoolguy deleted the xcframeworks branch September 10, 2020 15:55

sgtcoolguy mentioned this pull request Sep 10, 2020

fix(ios): avoid provisioning profile issues when targeting iPhone device #12034

Merged

janvennemann mentioned this pull request Oct 1, 2020

fix(ios): ignore duplicate and unnecessary framework search paths #12146

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ios): use/support/build xcframeworks #12026

feat(ios): use/support/build xcframeworks #12026

sgtcoolguy commented Sep 9, 2020 •

edited

build commented Sep 9, 2020 •

edited

sgtcoolguy commented Sep 9, 2020

vijaysingh-axway Sep 9, 2020

sgtcoolguy Sep 9, 2020

vijaysingh-axway left a comment

ewanharris commented Sep 10, 2020

sgtcoolguy commented Sep 10, 2020

feat(ios): use/support/build xcframeworks #12026

feat(ios): use/support/build xcframeworks #12026

Conversation

sgtcoolguy commented Sep 9, 2020 • edited

build commented Sep 9, 2020 • edited

Tests:

sgtcoolguy commented Sep 9, 2020

vijaysingh-axway Sep 9, 2020

Choose a reason for hiding this comment

sgtcoolguy Sep 9, 2020

Choose a reason for hiding this comment

vijaysingh-axway left a comment

Choose a reason for hiding this comment

ewanharris commented Sep 10, 2020

sgtcoolguy commented Sep 10, 2020

sgtcoolguy commented Sep 9, 2020 •

edited

build commented Sep 9, 2020 •

edited