Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): ListView/TableView multiselection events only fired when tapping checkboxes #13107

Merged
merged 3 commits into from
Oct 20, 2021

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28548

Summary:

  • ListView "itemsselected" event only fired when tapping item checkboxes. Not fired when tapping any other part of the item such as the title.
  • TableView "rowsselected" event only fired when tapping row checkboxes. Not fired when tapping any other part of the row such as the title.
  • Issue is item selection/de-selection still occurs, but not event gets fired. This makes it hard to track user selection unless you use a timer. Use-case would be to display a selection count onscreen.

ListView Test:

  1. Build and run ListViewSelectionCountTest.js attached to TIMOB-28548 on iOS.
  2. Tap on the "Edit" button.
  3. Tap on a list item's text and verify selection count increases. (This did not work before.)
  4. Tap on the selected list item's text to de-select it and verify count decreases. (This did not work before.)
  5. Tap on a list item's checkbox and verify selection count increases.
  6. Tap on a selected list item's checkbox to de-select it and verify count decreases.

TableView Test:

  1. Build and run TableViewSelectionCountTest.js attached to TIMOB-28548 on iOS.
  2. Tap on the "Edit" button.
  3. Tap on a row's text and verify selection count increases. (This did not work before.)
  4. Tap on the selected row's text to de-select it and verify count decreases. (This did not work before.)
  5. Tap on a row's checkbox and verify selection count increases.
  6. Tap on a selected row's checkbox to de-select it and verify count decreases.

@build
Copy link
Contributor

build commented Oct 7, 2021

Warnings
⚠️ Tests have failed, see below for more information.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 2 tests have failed There are 2 tests failing and 1162 skipped out of 20784 total tests.
📖

💾 Here's the generated SDK zipfile.

Tests:

ClassnameNameTimeError
android.emulator.5.0.Titanium.UI.View"after all" hook for "rgba fallback" (5.0.2)20.329
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.5.0.Titanium.UI.View"after each" hook for "getOrCreateView() should always return a View" (5.0.2)10.278
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)

Generated by 🚫 dangerJS against 3c871a0

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@jquick-axway jquick-axway merged commit 09e9044 into tidev:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants