fix(android): lower build gradle #13571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
hansemannn
reviewed
Sep 21, 2022
| @@ -2184,6 +2184,7 @@ AndroidBuilder.prototype.generateRootProjectFiles = async function generateRootP | |||
| const gradleProperties = await gradlew.fetchDefaultGradleProperties(); | |||
| gradleProperties.push({ key: 'android.useAndroidX', value: 'true' }); | |||
| gradleProperties.push({ key: 'android.enableJetifier', value: 'true' }); | |||
| gradleProperties.push({ key: 'android.suppressUnsupportedCompileSdk', value: '33' }); | |||
There was a problem hiding this comment.
This line was not changed in the 11_1_X branch, is it necessary?
There was a problem hiding this comment.
only to target SDK 33. Otherwise it will show a warning all the time. 11_1_X is not targeting 33 so I didn't include it there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13570
Test
currently SDK and apps have a different build.gradle since I can't update the SDKs version. It looks like modules don't like that 😄