fix(ios): build module platform/xcframwork symbolic links #13811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when app-thinning is used
fixed lint error
build module platform/*.xcframwork symbolic links
hansemannn
reviewed
Apr 20, 2023
cb1kenobi
requested changes
Apr 20, 2023
the entryData parameter works! :-) Co-authored-by: Chris Barber <chris.barber@vercel.com>
cb1kenobi
reviewed
Apr 20, 2023
cb1kenobi
requested changes
Apr 20, 2023
Co-authored-by: Chris Barber <chris.barber@vercel.com>
cb1kenobi
approved these changes
Apr 20, 2023
hansemannn
added a commit
that referenced
this pull request
Apr 24, 2023
* feat: add option to exclude dir(s) from compiling to assests catalog when app-thinning is used * Update gather.js fixed lint error * feat: fixed lint error * fixed RegEx Lint warning * fix(ios): build module platform/xcframwork symbolic links build module platform/*.xcframwork symbolic links * fix(ios): build module platform/xcframwork symbolic links * feat(ios): added scrollEnabled and removeInputAccessoryView to webView * Revert "feat(ios): added scrollEnabled and removeInputAccessoryView to webView" This reverts commit 5e6ffc3. * Update iphone/cli/commands/_buildModule.js the entryData parameter works! :-) Co-authored-by: Chris Barber <chris.barber@vercel.com> * chore: fix linting issue * chore: fix linting Co-authored-by: Chris Barber <chris.barber@vercel.com> --------- Co-authored-by: Chris Barber <chris.barber@vercel.com> Co-authored-by: Hans Knöchel <hansemannn@users.noreply.github.com>
narbs
pushed a commit
to narbs/titanium_mobile
that referenced
this pull request
Jun 7, 2023
* feat: add option to exclude dir(s) from compiling to assests catalog when app-thinning is used * Update gather.js fixed lint error * feat: fixed lint error * fixed RegEx Lint warning * fix(ios): build module platform/xcframwork symbolic links build module platform/*.xcframwork symbolic links * fix(ios): build module platform/xcframwork symbolic links * feat(ios): added scrollEnabled and removeInputAccessoryView to webView * Revert "feat(ios): added scrollEnabled and removeInputAccessoryView to webView" This reverts commit 5e6ffc3. * Update iphone/cli/commands/_buildModule.js the entryData parameter works! :-) Co-authored-by: Chris Barber <chris.barber@vercel.com> * chore: fix linting issue * chore: fix linting Co-authored-by: Chris Barber <chris.barber@vercel.com> --------- Co-authored-by: Chris Barber <chris.barber@vercel.com> Co-authored-by: Hans Knöchel <hansemannn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional Description:
fix to keep symbolic links in /platform/*.XCFramework folder for MacCatalyst xcframeworks when packaging the module.
Else the symlinks of MacCatalyst version of xcframework will be resolved and building the app for target 'macos' will fail!