Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update android dependencies #13813

Merged
merged 2 commits into from
May 3, 2023
Merged

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Apr 21, 2023

Changelogs I could find:

added a note about material lib into the "gradle update" issue. We can only raise that once we figure out how to update the gradle-plugin.

Tests
only compiled two bigger apps so far without any visual change or issues. But have to do some more tests e.g. build modules, use newly build modules in old SDK apps, ...

  • Build existing app with existing (pre 12.2.0) modules
  • build modules
  • use 12.2.0 module in 12.2.0 app
  • use 12.2.0 module in 12.0.0.GA app
  • use 12.2.0 module in 11.1.1.GA app (with compileSdkVersion 33)
  • Ti test suite 5167 Total Tests: 5167 passed, 0 failed, 0 skipped.
  • kitchensink
  • hyperloop-examples

@m1ga m1ga marked this pull request as ready for review April 22, 2023 17:11
@hansemannn
Copy link
Collaborator

@m1ga Any version updates until today? Otherwise, good to go.

@m1ga
Copy link
Contributor Author

m1ga commented May 3, 2023

no, should be fine with those version 👍

@hansemannn hansemannn merged commit a30b031 into master May 3, 2023
@m1ga m1ga deleted the 230421_android_libraries branch May 3, 2023 21:27
narbs pushed a commit to narbs/titanium_mobile that referenced this pull request Jun 7, 2023
* chore: update android dependencies

* chore: google-services
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants