fix(ios): drag-and-drop text in TextArea can crash on iOS 15

Fixes TIMOB-28556
tidev · Nov 17, 2021 · 5ebb9d2 · 5ebb9d2
1 parent 248763a
commit 5ebb9d2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/iphone/Classes/TiUITextArea.h b/iphone/Classes/TiUITextArea.h
@@ -18,6 +18,7 @@
 @property (nonatomic, readwrite, assign) BOOL enableCopy;
 
 - (void)setTouchHandler:(TiUIView *)handler;
+- (NSComparisonResult)comparePosition:(UITextPosition *)position toPosition:(UITextPosition *)other;
 
 @end
 

diff --git a/iphone/Classes/TiUITextArea.m b/iphone/Classes/TiUITextArea.m
@@ -38,6 +38,18 @@ - (void)setTouchHandler:(TiUIView *)handler
   touchHandler = handler;
 }
 
+- (NSComparisonResult)comparePosition:(UITextPosition *)position toPosition:(UITextPosition *)other
+{
+  NSComparisonResult result = NSOrderedAscending;
+  @try {
+    result = [super comparePosition:position toPosition:other];
+  }
+  @catch (NSException *ex) {
+    // Ignore exception that can occur on iOS 15 if "maxLength" trims text that was dragged-and-dropped.
+  }
+  return result;
+}
+
 - (BOOL)touchesShouldBegin:(NSSet *)touches withEvent:(UIEvent *)event inContentView:(UIView *)view
 {
   //If the content view is of type TiUIView touch events will automatically propagate
@@ -376,7 +388,7 @@ - (BOOL)textView:(UITextView *)tv shouldChangeTextInRange:(NSRange)range replace
     }
   }
 
-  return TRUE;
+  return YES;
 }
 
 - (void)setHandleLinks_:(id)args