Behave transparently on 304 if requester sets cache headers #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the incoming request proxied by the library has If-Modified-Since or If-None-Match headers, we should assume the requester has a cache of its own and send back 304 responses as is.
dontcallmedom
added a commit
to w3c/reffy
that referenced
this pull request
Feb 4, 2022
tidoust
reviewed
Feb 4, 2022
There was a problem hiding this comment.
I'll adjust the code because it misses something: when the refresh setting is set to never, if requester sends If-Modified-Since or If-None-Match and if version is cache matches the requested headers, the code should produce and return a 304 response.
In other words, the final 304 logic should rather be in readFromCache than right before it when a conditional request was made.
|
I cannot push to dontcallmedom/fetch-filecache-for-crawling, so made #7 instead, where I propose to continue the discussion and review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the incoming request proxied by the library has If-Modified-Since or If-None-Match headers, we should assume the requester has a cache of its own and send back 304 responses as is.