Allow other preprocessors #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiushiyan
commented
May 27, 2022
| collections | ||
| } | ||
|
|
||
| bind_metrics_iter_grid <- function(metrics, iter_grid) { |
There was a problem hiding this comment.
bind .config to metrics
qiushiyan
commented
May 27, 2022
| # prep training and validation data | ||
| training_frame_processed <- recipes::bake(preprocessor, new_data = training_frame) | ||
| val_frame_processed <- recipes::bake(preprocessor, new_data = val_frame) | ||
| training_forged <- tune:::forge_from_workflow(training_frame, |
There was a problem hiding this comment.
use forge_from_workflow instead of recipes::bake, works when there is no recipe
|
That that line is fine. I think that it's time to add tests (with recipes, formulas, and variable specifications). They'll have to skip for now but we can run them locally. |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should allow tuning when there is no recipe and other types of preprocessors #5.Not sure if we need to change this line https://github.com/topepo/agua/blob/e789ffa750262ffb31c46c50c41e755e9a8cd9d5/R/tune.R#L27 seems to work when there is no recipe.
We also need additional internal
tunefunctionsforge_from_workflowandfinalize_workflow_preprocessor