move pscl tidiers here from poissonreg #1133
Conversation
since it's only in Suggests
|
The test failures look like they are unrelated to this PR 👀 |
There was a problem hiding this comment.
Thank you, @hfrick!
Agreed that the check failures aren't related.
While we'll plan on making some changes to these tidiers before CRAN release, this PR looks good to get that initial transfer done!
|
Your comment about a smooth transition on the other PR made me remember that we could make the registration of the methods here conditional on the installed version of poissonreg, i.e. if there were already registered in poissonreg (through an older version), don't try to register them again here. I'll push some changes for you to review! |
| @@ -551,7 +551,8 @@ Imports: | |||
| rlang, | |||
| stringr, | |||
| tibble (>= 3.0.0), | |||
| tidyr (>= 1.0.0) | |||
| tidyr (>= 1.0.0), | |||
| vctrs | |||
There was a problem hiding this comment.
this dependency can be removed again when we register the methods unconditionally
| tidy_zeroinfl <- .tidy | ||
|
|
||
| #' @rdname tidy_zip | ||
| tidy_hurdle <- .tidy |
There was a problem hiding this comment.
I've left this so that we only need to change the _ back to the . when we register unconditionally (instead of using .tidy() directly in the registration in .onLoad().
|
Closing, with some background in this comment.🐙 |
|
This pull request has been automatically locked. If you believe the issue addressed here persists, please file a new PR (with a reprex: https://reprex.tidyverse.org) and link to this one. |
part of #1132
the corresponding PR on poissonreg is tidymodels/poissonreg#58