Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove speedglm Suggests #1155

Merged
merged 2 commits into from
May 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,6 @@ Suggests:
sp,
spdep (>= 1.1),
spatialreg,
speedglm,
spelling,
survey,
survival,
Expand Down
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# broom (development version)

* Removed speedglm as a Suggested package following the package's removal from CRAN. If the package has not made it to CRAN by the next release, the tidiers for those objects will be hard-deprecated.

# broom 1.0.4

* Added an `intercept` argument to `tidy.aov()`, a logical indicating whether to include information on the intercept as the first row of results (#1144 by `@victor-vscn`).
Expand Down
8 changes: 3 additions & 5 deletions R/speedglm-speedglm-tidiers.R
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
#' @templateVar class speedglm
#' @template title_desc_tidy
#'
#' @param x A `speedglm` object returned from [speedglm::speedglm()].
#' @param x A `speedglm` object returned from `speedglm::speedglm()`.
#' @template param_confint
#' @template param_exponentiate
#' @template param_unused_dots
#'
#' @evalRd return_tidy(regression = TRUE)
#'
#' @examplesIf rlang::is_installed("speedglm")
#' @examplesIf FALSE
#'
#' # load libraries for models and data
#' library(speedglm)
#' # library(speedglm)
#'
#' # generate data
#' clotting <- data.frame(
Expand All @@ -29,7 +29,6 @@
#' @aliases speedglm_tidiers
#' @export
#' @family speedlm tidiers
#' @seealso [speedglm::speedglm()]
tidy.speedglm <- function(x, conf.int = FALSE, conf.level = 0.95,
exponentiate = FALSE, ...) {
ret <- as_tibble(coef(summary(x)), rownames = "term")
Expand Down Expand Up @@ -72,7 +71,6 @@ tidy.speedglm <- function(x, conf.int = FALSE, conf.level = 0.95,
#'
#' @export
#' @family speedlm tidiers
#' @seealso [speedglm::speedlm()]
glance.speedglm <- function(x, ...) {
as_glance_tibble(
null.deviance = x$nulldev,
Expand Down
9 changes: 3 additions & 6 deletions R/speedglm-speedlm-tidiers.R
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
#' @templateVar class speedlm
#' @template title_desc_tidy
#'
#' @param x A `speedlm` object returned from [speedglm::speedlm()].
#' @param x A `speedlm` object returned from `speedglm::speedlm()`.
#' @template param_confint
#' @template param_unused_dots
#'
#' @evalRd return_tidy(regression = TRUE)
#'
#' @examplesIf rlang::is_installed("speedglm")
#' @examplesIf FALSE
#'
#' # load modeling library
#' library(speedglm)
#' # dlibrary(speedglm)
#'
#' # fit model
#' mod <- speedlm(mpg ~ wt + qsec, data = mtcars, fitted = TRUE)
Expand All @@ -23,7 +23,6 @@
#' @aliases speedlm_tidiers
#' @export
#' @family speedlm tidiers
#' @seealso [speedglm::speedlm()], [tidy.lm()]
#' @include stats-lm-tidiers.R
tidy.speedlm <- function(x, conf.int = FALSE, conf.level = 0.95, ...) {
check_ellipses("exponentiate", "tidy", "speedlm", ...)
Expand Down Expand Up @@ -66,7 +65,6 @@ tidy.speedlm <- function(x, conf.int = FALSE, conf.level = 0.95, ...) {
#'
#' @export
#' @family speedlm tidiers
#' @seealso [speedglm::speedlm()]
glance.speedlm <- function(x, ...) {
s <- summary(x)
as_glance_tibble(
Expand Down Expand Up @@ -98,7 +96,6 @@ glance.speedlm <- function(x, ...) {
#' @importFrom rlang expr enexpr
#' @export
#' @family speedlm tidiers
#' @seealso [speedglm::speedlm()]
augment.speedlm <- function(x, data = model.frame(x), newdata = NULL, ...) {
# this is a hacky way to prevent the following bug:
# speedglm::speedglm(hp ~ log(mpg), mtcars, fitted = TRUE)
Expand Down
8 changes: 3 additions & 5 deletions man/augment.speedlm.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 3 additions & 5 deletions man/glance.speedglm.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 3 additions & 5 deletions man/glance.speedlm.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 3 additions & 5 deletions man/tidy.speedglm.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 3 additions & 5 deletions man/tidy.speedlm.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/testthat/test-speedglm-speedglm.R
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ skip_if_not_installed("modeltests")
library(modeltests)

skip_if_not_installed("speedglm")
library(speedglm)
# library(speedglm)

clotting <- data.frame(
u = c(5, 10, 15, 20, 30, 40, 60, 80, 100),
Expand Down
4 changes: 4 additions & 0 deletions tests/testthat/test-speedglm-speedlm.R
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ context("speedglm")

skip_on_cran()

test_that("restore speedglm testing if back on CRAN, remove tidiers if not", {
expect_false(Sys.Date() > "2023-07-01")
})

skip_if_not_installed("modeltests")
library(modeltests)

Expand Down
Loading