-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silence name repair #1182
Silence name repair #1182
Conversation
Thank you for the PR! Could you provide a reprex demonstrating where you see name repair issues arising? |
Removing the transitions from |
From the tests: library(modeltests)
#> Warning: le package 'modeltests' a été compilé avec la version R 4.3.2
library(broom)
mat <- scale(as.matrix(USJudgeRatings))
s <- svd(mat)
p <- prcomp(mat)
tdu <- tidy(s, matrix = "u")
#> New names:
#> • `` -> `...1`
#> • `` -> `...2`
#> • `` -> `...3`
#> • `` -> `...4`
#> • `` -> `...5`
#> • `` -> `...6`
#> • `` -> `...7`
#> • `` -> `...8`
#> • `` -> `...9`
#> • `` -> `...10`
#> • `` -> `...11`
#> • `` -> `...12`
tdd <- tidy(s, matrix = "d")
tdv <- tidy(s, matrix = "v")
#> New names:
#> • `` -> `...1`
#> • `` -> `...2`
#> • `` -> `...3`
#> • `` -> `...4`
#> • `` -> `...5`
#> • `` -> `...6`
#> • `` -> `...7`
#> • `` -> `...8`
#> • `` -> `...9`
#> • `` -> `...10`
#> • `` -> `...11`
#> • `` -> `...12` Created on 2023-12-05 with reprex v2.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This pull request has been automatically locked. If you believe the issue addressed here persists, please file a new PR (with a reprex: https://reprex.tidyverse.org) and link to this one. |
Using unique_quiet instead of unique.
the tidy_svd method produces many messages to the console right now. This PR silences them
I captured some conditions with
&
(unrelated) that I can revert if you'd like