Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence name repair #1182

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Silence name repair #1182

merged 4 commits into from
Dec 5, 2023

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Dec 5, 2023

Using unique_quiet instead of unique.

the tidy_svd method produces many messages to the console right now. This PR silences them

I captured some conditions with & (unrelated) that I can revert if you'd like

@olivroy olivroy mentioned this pull request Dec 5, 2023
@simonpcouch
Copy link
Collaborator

Thank you for the PR! Could you provide a reprex demonstrating where you see name repair issues arising?

@simonpcouch
Copy link
Collaborator

Removing the transitions from & to && would be great, yes. Feel free to file a separate PR/issue if you see errors resulting from their usage.

@olivroy
Copy link
Contributor Author

olivroy commented Dec 5, 2023

From the tests:

library(modeltests)
#> Warning: le package 'modeltests' a été compilé avec la version R 4.3.2
library(broom)
mat <- scale(as.matrix(USJudgeRatings))
s <- svd(mat)
p <- prcomp(mat)
tdu <- tidy(s, matrix = "u")
#> New names:
#> • `` -> `...1`
#> • `` -> `...2`
#> • `` -> `...3`
#> • `` -> `...4`
#> • `` -> `...5`
#> • `` -> `...6`
#> • `` -> `...7`
#> • `` -> `...8`
#> • `` -> `...9`
#> • `` -> `...10`
#> • `` -> `...11`
#> • `` -> `...12`
tdd <- tidy(s, matrix = "d")
tdv <- tidy(s, matrix = "v")
#> New names:
#> • `` -> `...1`
#> • `` -> `...2`
#> • `` -> `...3`
#> • `` -> `...4`
#> • `` -> `...5`
#> • `` -> `...6`
#> • `` -> `...7`
#> • `` -> `...8`
#> • `` -> `...9`
#> • `` -> `...10`
#> • `` -> `...11`
#> • `` -> `...12`

Created on 2023-12-05 with reprex v2.0.2

Copy link
Collaborator

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@simonpcouch simonpcouch merged commit a2b69a7 into tidymodels:main Dec 5, 2023
5 of 9 checks passed
@olivroy olivroy deleted the silence branch December 5, 2023 22:06
Copy link

This pull request has been automatically locked. If you believe the issue addressed here persists, please file a new PR (with a reprex: https://reprex.tidyverse.org) and link to this one.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants