Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate single predictor models in tidy.rq and tidy.rqs. Fixes #354 #378

merged 1 commit into from Jun 18, 2018


Copy link

I've tried to tackle #354 by adding columns conf.low and conf.high set to NA, and added two new test cases to catch the old bug. In the process I also discovered a typo in the documentation about how confidence intervals are calculated when se.type = 'rank', so I fixed that and added details about the new implementation.

@alexpghayes alexpghayes merged commit 9f96401 into tidymodels:master Jun 18, 2018
Copy link

Thank you, this is a fantastic PR!

P.S. I'm a big fan of your blog.

Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants