-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds tidy-method form summary_emm-objects. #691
Conversation
Hey! Thanks for the PR! I don't use |
Hi Alex, of course! My main motivation for this PR is that > fit <- lm(sales1 ~ price1 + price2 + day + store, data = oranges)
> joint_tests_summary <- joint_tests(fit)
> joint_tests_summary
model term df1 df2 F.ratio p.value
day 5 23 4.879 0.0035
store 5 23 2.522 0.0583 The output of > class(joint_tests_summary)
[1] "summary_emm" "data.frame" Currently the By separating the call to Another motivation is that I use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I'm on board. Let's just make sure that the information in your comment above makes it into the documentation!
Co-Authored-By: alex hayes <alexpghayes@gmail.com>
- Adds joint_tests()-example - Removes strict = FALSE from tests
Thanks for the comments. I just pushed a commit that makes the requested changes. |
Can you merge in recent updates from the |
Of course! There should be no more merge conflicts now. |
This comment has been minimized.
This comment has been minimized.
Wonderful, thank you! Does this close #692? |
I'm afraid, closing that issue will be a little more work and another PR. I've started on it but it'll be a little longer. |
* Adds tidy-method form summary_emm-objects. * Updates NEWS * Apply suggestions from code review Co-Authored-By: alex hayes <alexpghayes@gmail.com> * Makes requested changes for emmeans tidiers. (#691) - Adds joint_tests()-example - Removes strict = FALSE from tests * Roxygenizes documentation. * Improves consistency of post-hoc comparison tidies (i.e. glht, stats::TukeyHSD, and emmeans). See #692 * Fixes failing tests and roxygenizes. * Adds NEWS entry. * Fixes more failing tests. * Fix bug in emmeans and multcomp examples. * Implement revision suggested by @alexpghayes Co-Authored-By: alex hayes <alexpghayes@gmail.com> Co-authored-by: alex hayes <alexpghayes@gmail.com>
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Currently, the
tidy()
-methods for various objects fromemmeans
/lsmeans
summarize and subsequently tidy the input. This PR separates these two steps and adds a slightly extended tidier forsummary_emm
objects (returned by, for example,emmeans::joint_tests()
).