Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sparse matrix methods #100

Closed
topepo opened this issue Jul 25, 2019 · 4 comments
Closed

sparse matrix methods #100

topepo opened this issue Jul 25, 2019 · 4 comments
Labels
feature a feature request or enhancement

Comments

@topepo
Copy link
Member

topepo commented Jul 25, 2019

It would be nice to havedgCMatrix support (now that I have an application that can really use that)

@DavisVaughan
Copy link
Member

I would need a little bit more information about this. Currently mold() forces any matrix input into a data frame. That makes the output from mold() consistent across all interfaces (i.e. the predictors and outcomes are always data frames).

It would be pretty inconsistent to return a dgCMatrix in the predictors slot even if had performance improvements

@DavisVaughan DavisVaughan added the feature a feature request or enhancement label Apr 3, 2020
@juliasilge
Copy link
Member

I looked at this a bit yesterday and realized that it is going to be a significant undertaking. Being able get to something like this:

new_default_recipe_blueprint(
    mold = mold,
    forge = forge,
    intercept = intercept,
    allow_novel_levels = allow_novel_levels,
    composition = composition,
    fresh = fresh
  )

is going to be a significant improvement in quality of life in several domains, though.

@DavisVaughan
Copy link
Member

Closed by #150 (closed enough for now, at least). We can revisit in the future as needed

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants