Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe don't allow for type = flexibility #8

Closed
DavisVaughan opened this issue Feb 14, 2019 · 1 comment · Fixed by #17
Closed

Maybe don't allow for type = flexibility #8

DavisVaughan opened this issue Feb 14, 2019 · 1 comment · Fixed by #17

Comments

@DavisVaughan
Copy link
Member

DavisVaughan commented Feb 14, 2019

It would greatly simplify some things, and make it straightforward to add a run_model_matrix = FALSE arg to the formula method of mold() if we always returned a tibble.

It would also generally clean up the mold() fn call. And things would generally be more type stable for the developer, at the cost of some performance loss if the user passes in a matrix to mold(x = <matrix>) and then the developer wants that back as a matrix. (Then again, they wouldn't have to use mold() if they didn't want to, and we could export the add_intercept_column() fn if we wanted to)

DavisVaughan added a commit that referenced this issue Feb 14, 2019
DavisVaughan added a commit that referenced this issue Feb 14, 2019
- Consistently return a tibble for the predictors
- Closes (#8)
@github-actions
Copy link

github-actions bot commented Jul 1, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant