add prop argument to rep_slice_sample #362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses a rep_sample_internal function to error more informatively without any match.call trickiness to figure out which of size or n is the right thing to mention in an error. introduces a prop argument, but ignored so far!
adds an example with prop and generally uses rep_slice_sample() over the superseded rep_sample_n(), as well as adding a NEWS entry
|
I'll a little bit short on time lately. I remember about this :) |
echasnovski
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
I am going to go ahead and approve these. @simonpcouch , you did a great job dealing with a clutter of overlapping but slightly different functionality. I think that my initial reaction of "overcomplication" comes from two issues:
- Confusing interception of functionalities and overall implementation design. This should be fixed with a complete ideological refactor (will open an issue).
- Having all
size,n,prop,in_slice, andmissing_sizeinrep_sample_internal(). It is probably a good idea to validate sample size in every function (rep_sample_n()andrep_slice_sample()) separately and have*_internal()only have singlesizeargument.
|
Closing in favor of #363. :-) |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
propargument torep_slice_sample()andrep_sample_n()as an alternative to then/sizearguments for specifying the proportion of rows in the supplied data to sample per replicate.Closes #361. :-)